Merge branch 'maint-0.4.3'

This commit is contained in:
Nick Mathewson 2020-03-12 13:45:06 -04:00
commit 8bc4822ba6

View File

@ -490,7 +490,8 @@ test_options_validate__uname_for_server(void *ignored)
#endif #endif
options_test_data_t *tdata = get_options_test_data( options_test_data_t *tdata = get_options_test_data(
"ORPort 127.0.0.1:5555"); "ORPort 127.0.0.1:5555\n"
"ContactInfo nobody@example.com");
setup_capture_of_logs(LOG_WARN); setup_capture_of_logs(LOG_WARN);
MOCK(get_uname, fixed_get_uname); MOCK(get_uname, fixed_get_uname);
@ -636,9 +637,11 @@ test_options_validate__contactinfo(void *ignored)
ret = options_validate(NULL, tdata->opt, &msg); ret = options_validate(NULL, tdata->opt, &msg);
tt_int_op(ret, OP_EQ, 0); tt_int_op(ret, OP_EQ, 0);
expect_log_msg( expect_log_msg(
"Your ContactInfo config option is not" "Your ContactInfo config option is not set. Please strongly "
" set. Please consider setting it, so we can contact you if your" "consider setting it, so we can contact you if your relay is "
" server is misconfigured or something else goes wrong.\n"); "misconfigured, end-of-life, or something else goes wrong. It "
"is also possible that your relay might get rejected from the "
"network due to a missing valid contact address.\n");
tor_free(msg); tor_free(msg);
free_options_test_data(tdata); free_options_test_data(tdata);
@ -648,9 +651,11 @@ test_options_validate__contactinfo(void *ignored)
ret = options_validate(NULL, tdata->opt, &msg); ret = options_validate(NULL, tdata->opt, &msg);
tt_int_op(ret, OP_EQ, 0); tt_int_op(ret, OP_EQ, 0);
expect_no_log_msg( expect_no_log_msg(
"Your ContactInfo config option is not" "Your ContactInfo config option is not set. Please strongly "
" set. Please consider setting it, so we can contact you if your" "consider setting it, so we can contact you if your relay is "
" server is misconfigured or something else goes wrong.\n"); "misconfigured, end-of-life, or something else goes wrong. It "
"is also possible that your relay might get rejected from the "
"network due to a missing valid contact address.\n");
tor_free(msg); tor_free(msg);
done: done: