mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-10 05:03:43 +01:00
Die if tor_vasprintf fails in connection_printf_to_buf
tor_asprintf already asserts if it fails.
This commit is contained in:
parent
b70a0a4375
commit
8aad677bb7
9
changes/bug3428b
Normal file
9
changes/bug3428b
Normal file
@ -0,0 +1,9 @@
|
||||
o Minor bugfixes:
|
||||
- Abort if tor_vasprintf fails in connection_printf_to_buf (a
|
||||
utility function used in the control-port code). This shouldn't
|
||||
ever happen unless Tor is completely out of memory, but if it
|
||||
had happened and Tor somehow recovered from it, Tor could have
|
||||
sent a log message to a control port in the middle of a reply to
|
||||
a controller command. Fixes part of bug 3428.
|
||||
|
||||
|
@ -503,8 +503,8 @@ connection_printf_to_buf(control_connection_t *conn, const char *format, ...)
|
||||
va_end(ap);
|
||||
|
||||
if (len < 0) {
|
||||
log_warn(LD_BUG, "Unable to format string for controller.");
|
||||
return;
|
||||
log_err(LD_BUG, "Unable to format string for controller.");
|
||||
tor_assert(0);
|
||||
}
|
||||
|
||||
connection_write_to_buf(buf, (size_t)len, TO_CONN(conn));
|
||||
|
Loading…
Reference in New Issue
Block a user