nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

clarify three comments

Browse Source 
based on code-spelunking with nickm
This commit is contained in:
Roger Dingledine 2021-05-27 14:22:22 -04:00
parent 111e6e7f26
commit 896ab165d9
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/or/circuitbuild.c
View File

@ -2019,7 +2019,7 @@ cpath_build_state_to_crn_ipv6_extend_flag(const cpath_build_state_t *state,
} }
/** Decide a suitable length for circ's cpath, and pick an exit /** Decide a suitable length for circ's cpath, and pick an exit
* router (or use <b>exit</b> if provided). Store these in the * router (or use <b>exit_ei</b> if provided). Store these in the
* cpath. * cpath.
* *
* If <b>is_hs_v3_rp_circuit</b> is set, then this exit should be suitable to * If <b>is_hs_v3_rp_circuit</b> is set, then this exit should be suitable to
@ -2072,7 +2072,7 @@ onion_pick_cpath_exit(origin_circuit_t *circ, extend_info_t *exit_ei,
return 0; return 0;
} }
/** Give <b>circ</b> a new exit destination to <b>exit</b>, and add a /** Give <b>circ</b> a new exit destination to <b>exit_ei</b>, and add a
* hop to the cpath reflecting this. Don't send the next extend cell -- * hop to the cpath reflecting this. Don't send the next extend cell --
* the caller will do this if it wants to. * the caller will do this if it wants to.
*/ */
@ -2114,8 +2114,6 @@ circuit_extend_to_new_exit(origin_circuit_t *circ, extend_info_t *exit_ei)
return -1; return -1;
} }
// XXX: Should cannibalized circuits be dirty or not? Not easy to say..
return 0; return 0;
} }