Fix bug 4367: correctly detect auth_challenge cells we can't use

Found by frosty_un, bugfix on 0.2.3.6-alpha, fix suggested by arma.
This commit is contained in:
Nick Mathewson 2011-11-03 11:52:35 -04:00
parent d029c3223a
commit 88c4b425bd
2 changed files with 6 additions and 1 deletions

5
changes/bug4367 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes:
- Successfully detect AUTH_CHALLENGE cells with no recognized
authentication type listed. Fixes bug 4367; bugfix on 0.2.3.6-alpha.
Found by frosty_un.

View File

@ -1100,7 +1100,7 @@ command_process_auth_challenge_cell(var_cell_t *cell, or_connection_t *conn)
conn->handshake_state->received_auth_challenge = 1;
if (use_type && public_server_mode(get_options())) {
if (use_type >= 0 && public_server_mode(get_options())) {
log_info(LD_OR, "Got an AUTH_CHALLENGE cell from %s:%d: Sending "
"authentication",
safe_str(conn->_base.address), conn->_base.port);