Increase the length of the buffer in smartlist_string_num_isin().

This was harmless, since we only used this for checking for lists of
port values, but it's the principle of the thing.

Fixes 3175; bugfix on 0.1.0.1-rc
This commit is contained in:
Nick Mathewson 2011-05-15 22:13:53 -04:00
parent ede102fd46
commit 83fe07d3f2
2 changed files with 8 additions and 1 deletions

7
changes/bug3175 Normal file
View File

@ -0,0 +1,7 @@
o Minor bugfixes:
- Resolve an untriggerable issue in smartlist_string_num_isin(),
where if the function had ever in the future been used to check
for the presence of a too-large number, it would have given an
incorrect result. (Fortunately, we only used it for 16-bit
values.) Fixes bug 3175; bugfix on Tor 0.1.0.1-rc.

View File

@ -210,7 +210,7 @@ smartlist_string_isin_case(const smartlist_t *sl, const char *element)
int
smartlist_string_num_isin(const smartlist_t *sl, int num)
{
char buf[16];
char buf[32]; /* long enough for 64-bit int, and then some. */
tor_snprintf(buf,sizeof(buf),"%d", num);
return smartlist_string_isin(sl, buf);
}