nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Explain why the XXXX021 in connection_or.c was there, and explain why it doesn' actually need to get fixed in 0.2.1, I think.

Browse Source 
svn:r17819
This commit is contained in:
Nick Mathewson 2008-12-29 19:57:13 +00:00
parent 45bd6c650d
commit 83491796ee
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/or/connection_or.c
View File

@ -633,7 +633,15 @@ connection_or_group_set_badness(or_connection_t *head)
* every other open connection. If it's non-canonical, mark as bad
* every other open connection to the same address.
*
* XXXX021.
* XXXX This isn't optimal; if we have connections to an OR at multiple
* addresses, we'd like to pick the best _for each address_, and mark as
* bad every open connection that isn't best for its address. But this
* can only occur in cases where the other OR is old (so we have no
* canonical connection to it), or where all the connections to the OR are
* at noncanonical addresses and we have no good direct connection (which
* means we aren't at risk of attaching circuits to it anyway). As
* 0.1.2.x dies out, the first case will go away, and the second one is
* "mostly harmless", so a fix can wait until somebody is bored.
*/
for (or_conn = head; or_conn; or_conn = or_conn->next_with_same_id) {
if (or_conn->_base.marked_for_close ||