Recalculate voting schedule first when getting a new consensus

Because the HS and SR subsystems can use the voting schedule early (with the
changes in #23623 making the SR subsystem using the static voting schedule
object), we need to recalculate the schedule very early when setting the new
consensus.

Fixes #24161

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2017-11-07 11:08:12 -05:00
parent 9d848ca58a
commit 8171d9f50f

View File

@ -1939,13 +1939,17 @@ networkstatus_set_current_consensus(const char *consensus,
} }
if (is_usable_flavor) { if (is_usable_flavor) {
/* The "current" consensus has just been set and it is a usable flavor so
* the first thing we need to do is recalculate the voting schedule static
* object so we can use the timings in there needed by some subsystems
* such as hidden service and shared random. */
dirvote_recalculate_timing(options, now);
nodelist_set_consensus(c); nodelist_set_consensus(c);
/* XXXXNM Microdescs: needs a non-ns variant. ???? NM*/ /* XXXXNM Microdescs: needs a non-ns variant. ???? NM*/
update_consensus_networkstatus_fetch_time(now); update_consensus_networkstatus_fetch_time(now);
dirvote_recalculate_timing(options, now);
/* Update ewma and adjust policy if needed; first cache the old value */ /* Update ewma and adjust policy if needed; first cache the old value */
old_ewma_enabled = cell_ewma_enabled(); old_ewma_enabled = cell_ewma_enabled();
/* Change the cell EWMA settings */ /* Change the cell EWMA settings */