nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 06:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

test: Fix coverity CID 1439129

Browse Source 
One HSv3 unit test used "tor_memeq()" without checking the return value. This
commit changes that to use "tt_mem_op()" to actually make the test validate
something :).

Signed-off-by: David Goulet <dgoulet@torproject.org>
This commit is contained in:
David Goulet 2018-09-10 10:28:35 -04:00
parent 064d3e7497
commit 7ff67d0e90
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/hs_test_helpers.c
View File

@ -241,11 +241,11 @@ hs_helper_desc_equal(const hs_descriptor_t *desc1,
hs_desc_authorized_client_t
*client1 = smartlist_get(desc1->superencrypted_data.clients, i),
*client2 = smartlist_get(desc2->superencrypted_data.clients, i);
tor_memeq(client1->client_id, client2->client_id,
tt_mem_op(client1->client_id, OP_EQ, client2->client_id,
sizeof(client1->client_id));
tor_memeq(client1->iv, client2->iv,
tt_mem_op(client1->iv, OP_EQ, client2->iv,
sizeof(client1->iv));
tor_memeq(client1->encrypted_cookie, client2->encrypted_cookie,
tt_mem_op(client1->encrypted_cookie, OP_EQ, client2->encrypted_cookie,
sizeof(client1->encrypted_cookie));
}
}