nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Note that a couple of line in control.c are supposed to be dead-code.

Browse Source 
I'm hoping not to have to litter the rest of our codebase with Coverity ignores, but I think these are the only one we need right now.

svn:r17602
This commit is contained in:
Nick Mathewson 2008-12-11 21:11:28 +00:00
parent 02e26ebc49
commit 7e351a6341
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/or/control.c
View File

@ -764,6 +764,8 @@ control_setconf_helper(control_connection_t *conn, uint32_t len, char *body,
msg = "553 Unable to set option";
break;
case SETOPT_OK:
/* coverity[dead_error_line]
* (It's okay if we can never get to this point.) */
msg = "551 Internal error";
tor_fragile_assert();
break;
@ -1191,8 +1193,11 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len,
err:
tor_free(password);
if (!errstr)
if (!errstr) {
/* coverity[dead_error_line]
* (It's okay if we can never get to this point.) */
errstr = "Unknown reason.";
}
connection_printf_to_buf(conn, "515 Authentication failed: %s\r\n",
errstr);
connection_mark_for_close(TO_CONN(conn));