nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-01 08:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug when parsing bwhist with unexpected Interval

Browse Source 
Previously, our state parsing code would fail to parse a bwhist
correctly if the Interval was anything other than the default
hardcoded 15 minutes.  This change makes the parsing less incorrect,
though the resulting history array might get strange values in it if
the intervals don't match the one we're using.  (That is, if stuff was
generated in 15 minute intervals, and we read it into an array that
expects 30 minute intervals, we're fine, since values can be combined
pairwise.  But if we generate data at 30 minute intervals and read it
into 15 minute intervals, alternating buckets will be empty.)

Bugfix on 0.1.1.11-alpha.
This commit is contained in:
Nick Mathewson 2011-01-10 13:06:50 -05:00
parent 8dd4ecd14e
commit 7e1502c0d1
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changes/1863_bwhist Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes
- Fix a bug in banwidth history state parsing that could have been
triggered if a future version of Tor ever changed the timing
granularity at which bandwidth history is measured. Bugfix on
Tor 0.1.1.11-alpha.

6
src/or/rephist.c
View File

@ -1165,6 +1165,8 @@ rep_hist_load_mtbf_data(time_t now)
* totals? */ * totals? */
#define NUM_SECS_ROLLING_MEASURE 10 #define NUM_SECS_ROLLING_MEASURE 10
/** How large are the intervals for which we track and report bandwidth use? */ /** How large are the intervals for which we track and report bandwidth use? */
/* XXXX Watch out! Before Tor 0.2.2.21-alpha, using any other value here would
* generate an unparseable state file. */
#define NUM_SECS_BW_SUM_INTERVAL (15*60) #define NUM_SECS_BW_SUM_INTERVAL (15*60)
/** How far in the past do we remember and publish bandwidth use? */ /** How far in the past do we remember and publish bandwidth use? */
#define NUM_SECS_BW_SUM_IS_VALID (24*60*60) #define NUM_SECS_BW_SUM_IS_VALID (24*60*60)
@ -1577,7 +1579,9 @@ rep_hist_load_bwhist_state_section(bw_array_t *b,
} }
if (start < now) { if (start < now) {
add_obs(b, start, v); add_obs(b, start, v);
start += NUM_SECS_BW_SUM_INTERVAL; /* This will result in some fairly choppy history if s_interval
* is notthe same as NUM_SECS_BW_SUM_INTERVAL. XXXX */
start += s_interval;
} }
} SMARTLIST_FOREACH_END(cp); } SMARTLIST_FOREACH_END(cp);
} }