nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-30 23:53:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Document that we are unlikely to underflow session group IDs.

Browse Source
This commit is contained in:
Nick Mathewson 2012-06-15 10:05:21 -04:00
parent 2491fff5a6
commit 783f705ddc
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/or/connection.c
View File

@ -1048,7 +1048,12 @@ connection_listener_new(const struct sockaddr *listensockaddr,
if (port_cfg->session_group >= 0) { if (port_cfg->session_group >= 0) {
lis_conn->session_group = port_cfg->session_group; lis_conn->session_group = port_cfg->session_group;
} else { } else {
/* XXXX023 This can wrap after ~INT_MAX ports are opened. */ /* This can wrap afuter ~INT_MAX listeners are opened. But I don't
* believe that matters, since you would need to open a ridiculous
* number of listeners while keeping the early ones open before you ever
* hit this. An OR with a dozen ports open, for example, would have to
* close and re-open its listers every second for 4 years nonstop.
*/
lis_conn->session_group = global_next_session_group--; lis_conn->session_group = global_next_session_group--;
} }
} }