nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix off-by-one error when allocating memory in test_util_split_lines()

Browse Source 
Triggered "failed OVER picket-fence magic-number check (err 27)" when
memory debugging using dmalloc is enabled (at 'low' or higher).
This commit is contained in:
Steven Murdoch 2011-08-31 23:40:29 +01:00
parent 38ee959ea9
commit 76fde28475
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/test/test_util.c
View File

@ -1637,7 +1637,8 @@ test_util_split_lines(void *ptr)
for (i=0; tests[i].orig_line; i++) { for (i=0; tests[i].orig_line; i++) {
sl = smartlist_create(); sl = smartlist_create();
orig_line = tor_malloc(tests[i].orig_length); /* Allocate space for string and trailing NULL */
orig_line = tor_malloc(tests[i].orig_length + 1);
memcpy(orig_line, tests[i].orig_line, tests[i].orig_length + 1); memcpy(orig_line, tests[i].orig_line, tests[i].orig_length + 1);
tor_split_lines(sl, orig_line, tests[i].orig_length); tor_split_lines(sl, orig_line, tests[i].orig_length);