nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve log when unable to add sigs to pending consensus

Browse Source 
Closes ticket 24849.
This commit is contained in:
Nick Mathewson 2018-01-26 14:19:59 -05:00
parent 6ba2881aec
commit 75d4bd3497
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changes/ticket24849 Normal file
View File

@ -0,0 +1,3 @@
o Minor features (directory authority):
- When unable to add signatures to a pending consensus, log the reason
why. Closes ticket 24849.

8
src/or/dirvote.c
View File

@ -3551,7 +3551,13 @@ dirvote_add_signatures_to_pending_consensus(
}
r = networkstatus_add_detached_signatures(pc->consensus, sigs,
source, severity, msg_out);
log_info(LD_DIR,"Added %d signatures to consensus.", r);
if (r >= 0) {
log_info(LD_DIR,"Added %d signatures to consensus.", r);
} else {
log_fn(LOG_PROTOCOL_WARN, LD_DIR,
"Unable to add signatures to consensus: %s",
*msg_out ? *msg_out : "(unknown)");
}
if (r >= 1) {
char *new_signatures =