nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-13 06:33:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

start checking the return value of crypto_pk_asn1_encode() while

Browse Source 
we're trying to establish an introduction point. bug reported
by veracode.


svn:r13599
This commit is contained in:
Roger Dingledine 2008-02-19 23:33:02 +00:00
parent 42c4670e27
commit 707da4f73f
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/or/rendservice.c
View File

@ -850,8 +850,14 @@ rend_service_intro_has_opened(origin_circuit_t *circuit)
else else
intro_key = circuit->intro_key; intro_key = circuit->intro_key;
/* Build the payload for a RELAY_ESTABLISH_INTRO cell. */ /* Build the payload for a RELAY_ESTABLISH_INTRO cell. */
len = crypto_pk_asn1_encode(intro_key, buf+2, r = crypto_pk_asn1_encode(intro_key, buf+2,
RELAY_PAYLOAD_SIZE-2); RELAY_PAYLOAD_SIZE-2);
if (r < 0) {
log_warn(LD_BUG, "Internal error; failed to establish intro point.");
reason = END_CIRC_REASON_INTERNAL;
goto err;
}
len = r;
set_uint16(buf, htons((uint16_t)len)); set_uint16(buf, htons((uint16_t)len));
len += 2; len += 2;
memcpy(auth, circuit->cpath->prev->handshake_digest, DIGEST_LEN); memcpy(auth, circuit->cpath->prev->handshake_digest, DIGEST_LEN);