nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-11 05:03:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

prop224: Better missing hsdir index logs.

Browse Source 
Seems like hsdir index bugs are around to haunt us. Let's improve the
log messages to make debugging easier.
This commit is contained in:
George Kadianakis 2017-08-25 17:16:53 +03:00
parent ea5af8f442
commit 6d48e75685
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/or/hs_common.c
View File

@ -1206,12 +1206,16 @@ node_has_hsdir_index(const node_t *node, int is_for_next_period)
if (BUG(node->hsdir_index == NULL) || if (BUG(node->hsdir_index == NULL) ||
BUG(tor_mem_is_zero((const char*)node->hsdir_index->current, BUG(tor_mem_is_zero((const char*)node->hsdir_index->current,
DIGEST256_LEN))) { DIGEST256_LEN))) {
log_warn(LD_BUG, "Zero current index (ri: %p, rs: %p, md: %p)",
node->ri, node->rs, node->md);
return 0; return 0;
} }
if (is_for_next_period && if (is_for_next_period &&
BUG(tor_mem_is_zero((const char*)node->hsdir_index->next, BUG(tor_mem_is_zero((const char*)node->hsdir_index->next,
DIGEST256_LEN))) { DIGEST256_LEN))) {
log_warn(LD_BUG, "Zero next index (ri: %p, rs: %p, md: %p)",
node->ri, node->rs, node->md);
return 0; return 0;
} }