nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 14:23:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

prop224: Fix crosscert memory leaks on error

Browse Source
This commit is contained in:
David Goulet 2016-11-04 14:14:56 -04:00 committed by Nick Mathewson
parent 29ae8dcf96
commit 6ac85ca2b4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/or/hs_descriptor.c
View File

@ -306,7 +306,7 @@ encode_enc_key(const ed25519_keypair_t *sig_key,
} }
case HS_DESC_KEY_TYPE_CURVE25519: case HS_DESC_KEY_TYPE_CURVE25519:
{ {
int signbit; int signbit, ret;
char *encoded_cert, key_fp_b64[CURVE25519_BASE64_PADDED_LEN + 1]; char *encoded_cert, key_fp_b64[CURVE25519_BASE64_PADDED_LEN + 1];
ed25519_keypair_t curve_kp; ed25519_keypair_t curve_kp;
@ -323,11 +323,11 @@ encode_enc_key(const ed25519_keypair_t *sig_key,
if (!cross_cert) { if (!cross_cert) {
goto err; goto err;
} }
if (encode_cert(cross_cert, &encoded_cert)) { ret = encode_cert(cross_cert, &encoded_cert);
tor_cert_free(cross_cert); tor_cert_free(cross_cert);
if (ret) {
goto err; goto err;
} }
tor_cert_free(cross_cert);
if (curve25519_public_to_base64(key_fp_b64, if (curve25519_public_to_base64(key_fp_b64,
&ip->enc_key.curve25519.pubkey) < 0) { &ip->enc_key.curve25519.pubkey) < 0) {
tor_free(encoded_cert); tor_free(encoded_cert);