nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add an assertion to num_ntors_per_tap().

Browse Source 
This should please coverity, and fix CID 1415721.  It didn't
understand that networkstatus_get_param() always returns a value
between its minimum and maximum values.
This commit is contained in:
Nick Mathewson 2019-04-11 18:38:59 -04:00
parent 96e310911f
commit 66b07e7ec1
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/feature/relay/onion_queue.c
View File

@ -212,10 +212,12 @@ num_ntors_per_tap(void)
#define MIN_NUM_NTORS_PER_TAP 1 #define MIN_NUM_NTORS_PER_TAP 1
#define MAX_NUM_NTORS_PER_TAP 100000 #define MAX_NUM_NTORS_PER_TAP 100000
return networkstatus_get_param(NULL, "NumNTorsPerTAP", int result = networkstatus_get_param(NULL, "NumNTorsPerTAP",
DEFAULT_NUM_NTORS_PER_TAP, DEFAULT_NUM_NTORS_PER_TAP,
MIN_NUM_NTORS_PER_TAP, MIN_NUM_NTORS_PER_TAP,
MAX_NUM_NTORS_PER_TAP); MAX_NUM_NTORS_PER_TAP);
tor_assert(result > 0);
return result;
} }
/** Choose which onion queue we'll pull from next. If one is empty choose /** Choose which onion queue we'll pull from next. If one is empty choose