nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-30 15:43:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix CID 1444119

Browse Source 
Let's use the same function exit point for BUG() codepath that we're using
for every other exit condition. That way, we're not forgetting to clean up
the memarea.
This commit is contained in:
rl1987 2019-03-20 19:44:54 +02:00 committed by teor
parent d7a5fdcb74
commit 669ec64325
No known key found for this signature in database
GPG Key ID: 10FEAA0E7075672A
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changes/cid1444119 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (C correctness):
- Fix an unlikely memory leak in consensus_diff_apply(). Fixes bug 29824;
bugfix on 0.3.1.1-alpha. This is Coverity warning CID 1444119.

2
src/or/consdiff.c
View File

@ -1385,7 +1385,7 @@ consensus_diff_apply(const char *consensus,
r1 = consensus_compute_digest_as_signed(consensus, &d1); r1 = consensus_compute_digest_as_signed(consensus, &d1);
if (BUG(r1 < 0)) if (BUG(r1 < 0))
return NULL; // LCOV_EXCL_LINE goto done;
lines1 = smartlist_new(); lines1 = smartlist_new();
lines2 = smartlist_new(); lines2 = smartlist_new();