nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 21:23:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Handle crypto_pk_get_digest failures semi-sensibly

Browse Source 
Fixes bug 3106.
This commit is contained in:
Robert Ransom 2011-05-04 20:06:24 -07:00
parent 4126de6888
commit 66339f74b4
3 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
changes/warn-if-get_digest-fails Normal file
View File

@ -0,0 +1,6 @@
o Minor bugfixes:
- If we fail to compute the identity digest of a v3 legacy
keypair, warn, and don't use a buffer-full of junk instead.
Bugfix on 0.2.1.1-alpha; fixes bug 3106.

5
src/or/dirserv.c
View File

@ -2705,7 +2705,10 @@ dirserv_generate_networkstatus_vote_obj(crypto_pk_env_t *private_key,
if (options->V3AuthUseLegacyKey) {
authority_cert_t *c = get_my_v3_legacy_cert();
if (c) {
crypto_pk_get_digest(c->identity_key, voter->legacy_id_digest);
if (crypto_pk_get_digest(c->identity_key, voter->legacy_id_digest)) {
log_warn(LD_BUG, "Unable to compute digest of legacy v3 identity key");
memset(voter->legacy_id_digest, 0, DIGEST_LEN);
}
}
}

8
src/or/dirvote.c
View File

@ -3129,8 +3129,12 @@ dirvote_compute_consensuses(void)
authority_cert_t *cert = get_my_v3_legacy_cert();
legacy_sign = get_my_v3_legacy_signing_key();
if (cert) {
crypto_pk_get_digest(cert->identity_key, legacy_dbuf);
legacy_id_digest = legacy_dbuf;
if (crypto_pk_get_digest(cert->identity_key, legacy_dbuf)) {
log_warn(LD_BUG,
"Unable to compute digest of legacy v3 identity key");
} else {
legacy_id_digest = legacy_dbuf;
}
}
}