Reinstate address in warning message when binding non-locally

bug4020

Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
This commit is contained in:
Tom Fitzhenry 2012-04-26 22:14:01 +01:00 committed by Nick Mathewson
parent 613079fbc4
commit 655782f302

View File

@ -4348,15 +4348,15 @@ warn_nonlocal_client_ports(const smartlist_t *ports, const char *portname)
if (port->is_unix_addr) { if (port->is_unix_addr) {
/* Unix sockets aren't accessible over a network. */ /* Unix sockets aren't accessible over a network. */
} else if (!tor_addr_is_internal(&port->addr, 1)) { } else if (!tor_addr_is_internal(&port->addr, 1)) {
log_warn(LD_CONFIG, "You specified a public address for %sPort. " log_warn(LD_CONFIG, "You specified a public address '%s:%d' for %sPort. "
"Other people on the Internet might find your computer and " "Other people on the Internet might find your computer and "
"use it as an open proxy. Please don't allow this unless you " "use it as an open proxy. Please don't allow this unless you "
"have a good reason.", portname); "have a good reason.", fmt_addr(&port->addr), port->port, portname);
} else if (!tor_addr_is_loopback(&port->addr)) { } else if (!tor_addr_is_loopback(&port->addr)) {
log_notice(LD_CONFIG, "You configured a non-loopback address for " log_notice(LD_CONFIG, "You configured a non-loopback address '%s:%d' for "
"%sPort. This allows everybody on your local network to use " "%sPort. This allows everybody on your local network to use "
"your machine as a proxy. Make sure this is what you wanted.", "your machine as a proxy. Make sure this is what you wanted.",
portname); fmt_addr(&port->addr), port->port, portname);
} }
} SMARTLIST_FOREACH_END(port); } SMARTLIST_FOREACH_END(port);
} }