Start writing a how to review doc

This commit is contained in:
Nick Mathewson 2015-10-22 10:01:13 -04:00
parent 7dbcdfab58
commit 609c1e8870
2 changed files with 4 additions and 0 deletions

View File

@ -141,6 +141,9 @@ sure that we worked on MSVC6.
We don't use strcat or strcpy or sprintf of any of those notoriously broken We don't use strcat or strcpy or sprintf of any of those notoriously broken
old C functions. Use strlcat, strlcpy, or tor_snprintf/tor_asprintf instead. old C functions. Use strlcat, strlcpy, or tor_snprintf/tor_asprintf instead.
We don't call memcmp() directly. Use fast_memeq(), fast_memneq(),
tor_memeq(), or tor_memneq() for most purposes.
Functions not to write Functions not to write
~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~

View File

@ -43,6 +43,7 @@ EXTRA_DIST+= doc/asciidoc-helper.sh \
doc/HACKING/CodingStandards.txt \ doc/HACKING/CodingStandards.txt \
doc/HACKING/GettingStarted.txt \ doc/HACKING/GettingStarted.txt \
doc/HACKING/HelpfulTools.txt \ doc/HACKING/HelpfulTools.txt \
doc/HACKING/HowToReview.txt \
doc/HACKING/ReleasingTor.txt \ doc/HACKING/ReleasingTor.txt \
doc/HACKING/WritingTests.txt doc/HACKING/WritingTests.txt