nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-03 00:53:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean up (and mark for 0.2.2.) comments relating to non-beauty of current bug-743 fix.

Browse Source 
svn:r17966
This commit is contained in:
Nick Mathewson 2009-01-06 17:37:22 +00:00
parent 6f1ceaefaa
commit 5e44581412
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/or/rendclient.c
View File

@ -598,9 +598,9 @@ rend_client_rendezvous_acked(origin_circuit_t *circ, const char *request,
log_info(LD_REND,"Got rendezvous ack. This circuit is now ready for " log_info(LD_REND,"Got rendezvous ack. This circuit is now ready for "
"rendezvous."); "rendezvous.");
circ->_base.purpose = CIRCUIT_PURPOSE_C_REND_READY; circ->_base.purpose = CIRCUIT_PURPOSE_C_REND_READY;
/*XXXX This is a pretty brute approach. It'd be better to /* XXXX022 This is a pretty brute-force approach. It'd be better to
* attach only the connections that are waiting on this circuit, rather * attach only the connections that are waiting on this circuit, rather
* than trying to attach them all. See bug 743. */ * than trying to attach them all. See comments bug 743. */
/* If we already have the introduction circuit built, make sure we send /* If we already have the introduction circuit built, make sure we send
* the INTRODUCE cell _now_ */ * the INTRODUCE cell _now_ */
connection_ap_attach_pending(); connection_ap_attach_pending();
@ -666,10 +666,9 @@ rend_client_receive_rendezvous(origin_circuit_t *circ, const char *request,
onion_append_to_cpath(&circ->cpath, hop); onion_append_to_cpath(&circ->cpath, hop);
circ->build_state->pending_final_cpath = NULL; /* prevent double-free */ circ->build_state->pending_final_cpath = NULL; /* prevent double-free */
/*XXXX This is a pretty brute approach. It'd be better to /* XXXX022 This is a pretty brute-force approach. It'd be better to
* attach only the connections that are waiting on this circuit, rather * attach only the connections that are waiting on this circuit, rather
* than trying to attach them all. See bug 743.*/ * than trying to attach them all. See comments bug 743. */
/* */
connection_ap_attach_pending(); connection_ap_attach_pending();
return 0; return 0;
err: err: