Add a comment explaining reachability vs bandwidth self-tests

This is in response to a question about why we don't always log
orport self-tests as reachability tests.

I'm not 100% convinced that bandwidth self-tests are still useful,
but that's an issue for another day. :)
This commit is contained in:
Nick Mathewson 2020-07-01 10:33:27 -04:00
parent 2238b6320b
commit 5d956d797b

View File

@ -259,6 +259,9 @@ router_do_orport_reachability_checks(const routerinfo_t *me,
!orport_reachable ? "reachability" : "bandwidth",
family_name, fmt_addrport(&ei->addr, ei->port));
if (!orport_reachable) {
/* This is only a 'reachability test' if we don't already think that
* the port is reachable. If we _do_ think it's reachable, then
* it counts as a 'bandwidth test'. */
inform_testing_reachability(&ei->addr, ei->port, false);
}
circuit_launch_by_extend_info(CIRCUIT_PURPOSE_TESTING, ei,