nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-02 16:43:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Mark unreachable lines in crypto_ed25519.c

Browse Source
This commit is contained in:
Nick Mathewson 2016-05-03 12:18:50 -04:00
parent 8a536be705
commit 5b91e70a4f
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/common/crypto_ed25519.c
View File

@ -94,8 +94,8 @@ static const ed25519_impl_t *ed25519_impl = NULL;
static inline const ed25519_impl_t * static inline const ed25519_impl_t *
get_ed_impl(void) get_ed_impl(void)
{ {
if (PREDICT_UNLIKELY(ed25519_impl == NULL)) { if (BUG(ed25519_impl == NULL)) {
pick_ed25519_impl(); pick_ed25519_impl(); // LCOV_EXCL_LINE - We always call ed25519_init().
} }
return ed25519_impl; return ed25519_impl;
} }
@ -594,9 +594,12 @@ pick_ed25519_impl(void)
if (ed25519_impl_spot_check() == 0) if (ed25519_impl_spot_check() == 0)
return; return;
/* LCOV_EXCL_START
* unreachable unless ed25519_donna is broken */
log_warn(LD_CRYPTO, "The Ed25519-donna implementation seems broken; using " log_warn(LD_CRYPTO, "The Ed25519-donna implementation seems broken; using "
"the ref10 implementation."); "the ref10 implementation.");
ed25519_impl = &impl_ref10; ed25519_impl = &impl_ref10;
/* LCOV_EXCL_STOP */
} }
/* Initialize the Ed25519 implementation. This is neccessary if you're /* Initialize the Ed25519 implementation. This is neccessary if you're