mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-10 13:13:44 +01:00
Fix a use-after-free in validate_intro_point_failure. Bug 17401. Found w valgrind
This commit is contained in:
parent
542cc8a5ff
commit
5b2070198a
3
changes/bug17401
Normal file
3
changes/bug17401
Normal file
@ -0,0 +1,3 @@
|
||||
o Major bugfixes (correctness):
|
||||
- Fix a use-after-free bug in validate_intro_point_failure().
|
||||
Fixes bug 17401; bugfix on 0.2.7.3-rc.
|
@ -400,9 +400,10 @@ validate_intro_point_failure(const rend_service_descriptor_t *desc,
|
||||
/* This intro point is in our cache, discard it from the descriptor
|
||||
* because chances are that it's unusable. */
|
||||
SMARTLIST_DEL_CURRENT(desc->intro_nodes, intro);
|
||||
rend_intro_point_free(intro);
|
||||
/* Keep it for our new entry. */
|
||||
digestmap_set(new_entry->intro_failures, (char *) identity, ent_dup);
|
||||
/* Only free it when we're done looking at it. */
|
||||
rend_intro_point_free(intro);
|
||||
continue;
|
||||
}
|
||||
} SMARTLIST_FOREACH_END(intro);
|
||||
|
Loading…
Reference in New Issue
Block a user