nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Call strlen() once

Browse Source
This commit is contained in:
rl1987 2018-02-12 21:08:17 +01:00 committed by Nick Mathewson
parent b0ba4aa7e9
commit 5986589b48
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/common/util.c
View File

@ -1081,12 +1081,13 @@ string_is_valid_dest(const char *string)
{ {
char *tmp = NULL; char *tmp = NULL;
int retval; int retval;
size_t len = strlen(string);
tor_assert(string); tor_assert(string);
tor_assert(strlen(string) > 0); tor_assert(len > 0);
if (string[0] == '[' && string[strlen(string) - 1] == ']') if (string[0] == '[' && string[len - 1] == ']')
string = tmp = tor_strndup(string + 1, strlen(string) - 2); string = tmp = tor_strndup(string + 1, len - 2);
retval = string_is_valid_ipv4_address(string) || retval = string_is_valid_ipv4_address(string) ||
string_is_valid_ipv6_address(string) || string_is_valid_ipv6_address(string) ||