nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 05:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add an assertion to pathbias_get_scale_ratio()

Browse Source 
This should please coverity, and fix CID 1415723.  It didn't understand
that networkstatus_get_param() always returns a value between its
minimum and maximum values.
This commit is contained in:
Nick Mathewson 2019-04-11 18:38:59 -04:00
parent adeecce53b
commit 55690d05bd
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/feature/client/circpathbias.c
View File

@ -176,6 +176,7 @@ pathbias_get_scale_threshold(const or_options_t *options)
static double
pathbias_get_scale_ratio(const or_options_t *options)
{
(void) options;
/*
* The scale factor is the denominator for our scaling
* of circuit counts for our path bias window.
@ -185,7 +186,8 @@ pathbias_get_scale_ratio(const or_options_t *options)
*/
int denominator = networkstatus_get_param(NULL, "pb_scalefactor",
2, 2, INT32_MAX);
(void) options;
tor_assert(denominator > 0);
/**
* The mult factor is the numerator for our scaling
* of circuit counts for our path bias window. It