Add changes file for #30381.

changes/bug30381

@@ -0,0 +1,9 @@
+  o Major features (controller):
+    - New ONION_CLIENT_AUTH_ADD control port command to add client-side onion
+      service client authorization credentials. Closes part of ticket 30381.
+    - New ONION_CLIENT_AUTH_REMOVE control port command to remove client-side
+      onion service client authorization credentials. Closes part of ticket
+      30381.
+    - New ONION_CLIENT_AUTH_VIEW control port command to view stored
+      client-side onion service client authorization credentials. Closes part
+      of ticket 30381.

scripts/maint/practracker/exceptions.txt

@@ -33,12 +33,12 @@
 #
 # Remember: It is better to fix the problem than to add a new exception!
 
-problem file-size /src/app/config/config.c 7200
+problem file-size /src/app/config/config.c 7212
 problem include-count /src/app/config/config.c 80
-problem function-size /src/app/config/config.c:options_act_reversible() 296
+problem function-size /src/app/config/config.c:options_act_reversible() 298
 problem function-size /src/app/config/config.c:options_act() 381
 problem function-size /src/app/config/config.c:resolve_my_address() 190
-problem function-size /src/app/config/config.c:options_validate_cb() 785
+problem function-size /src/app/config/config.c:options_validate_cb() 780
 problem function-size /src/app/config/config.c:options_init_from_torrc() 188
 problem function-size /src/app/config/config.c:options_init_from_string() 103
 problem function-size /src/app/config/config.c:options_init_logs() 125
@@ -46,12 +46,12 @@ problem function-size /src/app/config/config.c:parse_bridge_line() 104
 problem function-size /src/app/config/config.c:pt_parse_transport_line() 189
 problem function-size /src/app/config/config.c:parse_dir_authority_line() 150
 problem function-size /src/app/config/config.c:parse_dir_fallback_line() 101
-problem function-size /src/app/config/config.c:port_parse_config() 446
+problem function-size /src/app/config/config.c:port_parse_config() 450
 problem function-size /src/app/config/config.c:parse_ports() 132
-problem file-size /src/app/config/or_options_st.h 1117
-problem include-count /src/app/main/main.c 68
+problem file-size /src/app/config/or_options_st.h 1115
+problem include-count /src/app/main/main.c 69
 problem function-size /src/app/main/main.c:dumpstats() 102
-problem function-size /src/app/main/main.c:tor_init() 111
+problem function-size /src/app/main/main.c:tor_init() 101
 problem function-size /src/app/main/main.c:sandbox_init_filter() 291
 problem function-size /src/app/main/main.c:run_tor_main_loop() 105
 problem function-size /src/app/main/ntmain.c:nt_service_install() 126
@@ -61,7 +61,7 @@ problem dependency-violation /src/core/crypto/onion_crypto.c 5
 problem dependency-violation /src/core/crypto/onion_fast.c 1
 problem dependency-violation /src/core/crypto/onion_tap.c 3
 problem dependency-violation /src/core/crypto/relay_crypto.c 9
-problem file-size /src/core/mainloop/connection.c 5575
+problem file-size /src/core/mainloop/connection.c 5577
 problem include-count /src/core/mainloop/connection.c 62
 problem function-size /src/core/mainloop/connection.c:connection_free_minimal() 185
 problem function-size /src/core/mainloop/connection.c:connection_listener_new() 324
@@ -75,10 +75,10 @@ problem function-size /src/core/mainloop/connection.c:connection_handle_write_im
 problem function-size /src/core/mainloop/connection.c:assert_connection_ok() 143
 problem dependency-violation /src/core/mainloop/connection.c 44
 problem dependency-violation /src/core/mainloop/cpuworker.c 12
-problem include-count /src/core/mainloop/mainloop.c 63
+problem include-count /src/core/mainloop/mainloop.c 64
 problem function-size /src/core/mainloop/mainloop.c:conn_close_if_marked() 108
 problem function-size /src/core/mainloop/mainloop.c:run_connection_housekeeping() 123
-problem dependency-violation /src/core/mainloop/mainloop.c 49
+problem dependency-violation /src/core/mainloop/mainloop.c 50
 problem dependency-violation /src/core/mainloop/mainloop_pubsub.c 1
 problem dependency-violation /src/core/mainloop/mainloop_sys.c 1
 problem dependency-violation /src/core/mainloop/netstatus.c 4
@@ -87,7 +87,7 @@ problem dependency-violation /src/core/or/address_set.c 1
 problem dependency-violation /src/core/or/cell_queue_st.h 1
 problem file-size /src/core/or/channel.c 3487
 problem dependency-violation /src/core/or/channel.c 9
-problem file-size /src/core/or/channel.h 780
+problem file-size /src/core/or/channel.h 781
 problem dependency-violation /src/core/or/channel.h 1
 problem dependency-violation /src/core/or/channelpadding.c 6
 problem function-size /src/core/or/channeltls.c:channel_tls_handle_var_cell() 160
@@ -103,7 +103,7 @@ problem function-size /src/core/or/circuitbuild.c:choose_good_exit_server_genera
 problem dependency-violation /src/core/or/circuitbuild.c 25
 problem include-count /src/core/or/circuitlist.c 55
 problem function-size /src/core/or/circuitlist.c:HT_PROTOTYPE() 109
-problem function-size /src/core/or/circuitlist.c:circuit_free_() 143
+problem function-size /src/core/or/circuitlist.c:circuit_free_() 146
 problem function-size /src/core/or/circuitlist.c:circuit_find_to_cannibalize() 101
 problem function-size /src/core/or/circuitlist.c:circuit_about_to_free() 120
 problem function-size /src/core/or/circuitlist.c:circuits_handle_oom() 117
@@ -112,7 +112,7 @@ problem dependency-violation /src/core/or/circuitlist.h 1
 problem function-size /src/core/or/circuitmux.c:circuitmux_set_policy() 109
 problem function-size /src/core/or/circuitmux.c:circuitmux_attach_circuit() 113
 problem dependency-violation /src/core/or/circuitmux_ewma.c 2
-problem file-size /src/core/or/circuitpadding.c 3096
+problem file-size /src/core/or/circuitpadding.c 3098
 problem function-size /src/core/or/circuitpadding.c:circpad_machine_schedule_padding() 113
 problem dependency-violation /src/core/or/circuitpadding.c 6
 problem file-size /src/core/or/circuitpadding.h 813
@@ -121,7 +121,7 @@ problem function-size /src/core/or/circuitpadding_machines.c:circpad_machine_cli
 problem dependency-violation /src/core/or/circuitpadding_machines.c 1
 problem function-size /src/core/or/circuitstats.c:circuit_build_times_parse_state() 123
 problem dependency-violation /src/core/or/circuitstats.c 11
-problem file-size /src/core/or/circuituse.c 3161
+problem file-size /src/core/or/circuituse.c 3162
 problem function-size /src/core/or/circuituse.c:circuit_is_acceptable() 128
 problem function-size /src/core/or/circuituse.c:circuit_expire_building() 394
 problem function-size /src/core/or/circuituse.c:circuit_log_ancient_one_hop_circuits() 126
@@ -129,16 +129,16 @@ problem function-size /src/core/or/circuituse.c:circuit_build_failed() 149
 problem function-size /src/core/or/circuituse.c:circuit_launch_by_extend_info() 108
 problem function-size /src/core/or/circuituse.c:circuit_get_open_circ_or_launch() 351
 problem function-size /src/core/or/circuituse.c:connection_ap_handshake_attach_circuit() 244
-problem dependency-violation /src/core/or/circuituse.c 23
+problem dependency-violation /src/core/or/circuituse.c 24
 problem function-size /src/core/or/command.c:command_process_create_cell() 156
 problem function-size /src/core/or/command.c:command_process_relay_cell() 132
 problem dependency-violation /src/core/or/command.c 8
-problem file-size /src/core/or/connection_edge.c 4601
+problem file-size /src/core/or/connection_edge.c 4640
 problem include-count /src/core/or/connection_edge.c 65
 problem function-size /src/core/or/connection_edge.c:connection_ap_expire_beginning() 117
 problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_rewrite() 193
 problem function-size /src/core/or/connection_edge.c:connection_ap_handle_onion() 185
-problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_rewrite_and_attach() 421
+problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_rewrite_and_attach() 420
 problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_send_begin() 111
 problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_socks_resolved() 101
 problem function-size /src/core/or/connection_edge.c:connection_exit_begin_conn() 185
@@ -151,7 +151,7 @@ problem function-size /src/core/or/connection_or.c:connection_or_group_set_badne
 problem function-size /src/core/or/connection_or.c:connection_or_client_learned_peer_id() 142
 problem function-size /src/core/or/connection_or.c:connection_or_compute_authenticate_cell_body() 231
 problem dependency-violation /src/core/or/connection_or.c 20
-problem dependency-violation /src/core/or/dos.c 5
+problem dependency-violation /src/core/or/dos.c 6
 problem dependency-violation /src/core/or/onion.c 2
 problem file-size /src/core/or/or.h 1107
 problem include-count /src/core/or/or.h 49
@@ -200,7 +200,7 @@ problem function-size /src/feature/control/control.c:connection_control_process_
 problem function-size /src/feature/control/control_auth.c:handle_control_authenticate() 186
 problem function-size /src/feature/control/control_cmd.c:handle_control_extendcircuit() 150
 problem function-size /src/feature/control/control_cmd.c:handle_control_add_onion() 256
-problem function-size /src/feature/control/control_cmd.c:add_onion_helper_keyarg() 117
+problem function-size /src/feature/control/control_cmd.c:add_onion_helper_keyarg() 118
 problem function-size /src/feature/control/control_events.c:control_event_stream_status() 118
 problem include-count /src/feature/control/control_getinfo.c 54
 problem function-size /src/feature/control/control_getinfo.c:getinfo_helper_misc() 108
@@ -225,8 +225,8 @@ problem function-size /src/feature/dircache/consdiffmgr.c:consdiffmgr_cleanup()
 problem function-size /src/feature/dircache/consdiffmgr.c:consdiffmgr_rescan_flavor_() 111
 problem function-size /src/feature/dircache/consdiffmgr.c:consensus_diff_worker_threadfn() 132
 problem function-size /src/feature/dircache/dircache.c:handle_get_current_consensus() 165
-problem function-size /src/feature/dircache/dircache.c:directory_handle_command_post() 119
-problem file-size /src/feature/dirclient/dirclient.c 3215
+problem function-size /src/feature/dircache/dircache.c:directory_handle_command_post() 124
+problem file-size /src/feature/dirclient/dirclient.c 3165
 problem include-count /src/feature/dirclient/dirclient.c 51
 problem function-size /src/feature/dirclient/dirclient.c:directory_get_from_dirserver() 126
 problem function-size /src/feature/dirclient/dirclient.c:directory_initiate_request() 201
@@ -256,7 +256,7 @@ problem function-size /src/feature/hs/hs_descriptor.c:desc_encode_v3() 101
 problem function-size /src/feature/hs/hs_descriptor.c:decrypt_desc_layer() 111
 problem function-size /src/feature/hs/hs_descriptor.c:decode_introduction_point() 122
 problem function-size /src/feature/hs/hs_descriptor.c:desc_decode_superencrypted_v3() 107
-problem function-size /src/feature/hs/hs_descriptor.c:desc_decode_encrypted_v3() 107
+problem function-size /src/feature/hs/hs_descriptor.c:desc_decode_encrypted_v3() 109
 problem file-size /src/feature/hs/hs_service.c 4172
 problem function-size /src/feature/keymgt/loadkey.c:ed_key_init_from_file() 326
 problem function-size /src/feature/nodelist/authcert.c:trusted_dirs_load_certs_from_string() 123
@@ -270,7 +270,7 @@ problem function-size /src/feature/nodelist/node_select.c:router_pick_directory_
 problem function-size /src/feature/nodelist/node_select.c:compute_weighted_bandwidths() 203
 problem function-size /src/feature/nodelist/node_select.c:router_pick_trusteddirserver_impl() 112
 problem function-size /src/feature/nodelist/nodelist.c:compute_frac_paths_available() 190
-problem file-size /src/feature/nodelist/routerlist.c 3241
+problem file-size /src/feature/nodelist/routerlist.c 3239
 problem function-size /src/feature/nodelist/routerlist.c:router_rebuild_store() 148
 problem function-size /src/feature/nodelist/routerlist.c:router_add_to_routerlist() 168
 problem function-size /src/feature/nodelist/routerlist.c:routerlist_remove_old_routers() 121
@@ -279,8 +279,8 @@ problem function-size /src/feature/nodelist/routerlist.c:update_extrainfo_downlo
 problem function-size /src/feature/relay/dns.c:dns_resolve_impl() 131
 problem function-size /src/feature/relay/dns.c:configure_nameservers() 161
 problem function-size /src/feature/relay/dns.c:evdns_callback() 108
-problem file-size /src/feature/relay/router.c 3524
-problem include-count /src/feature/relay/router.c 56
+problem file-size /src/feature/relay/router.c 3520
+problem include-count /src/feature/relay/router.c 57
 problem function-size /src/feature/relay/router.c:init_keys() 252
 problem function-size /src/feature/relay/router.c:get_my_declared_family() 114
 problem function-size /src/feature/relay/router.c:router_build_fresh_unsigned_routerinfo() 136