nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-30 23:53:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove MIN_METHOD_FOR_{PACKAGE_LINES,GUARDFRACTION,ED25519_ID_IN_MD}

Browse Source 
Also remove a rest for pre-19 microdesc versions.
This commit is contained in:
Nick Mathewson 2018-04-09 14:59:34 -04:00
parent caf766991d
commit 4d6f21bb6b
3 changed files with 3 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/or/dirvote.c
View File

@ -664,13 +664,6 @@ compute_consensus_method(smartlist_t *votes)
static int static int
consensus_method_is_supported(int method) consensus_method_is_supported(int method)
{ {
if (method == MIN_METHOD_FOR_ED25519_ID_IN_MD) {
/* This method was broken due to buggy code accidentally left in
* dircollate.c; do not actually use it.
*/
return 0;
}
return (method >= MIN_SUPPORTED_CONSENSUS_METHOD) && return (method >= MIN_SUPPORTED_CONSENSUS_METHOD) &&
(method <= MAX_SUPPORTED_CONSENSUS_METHOD); (method <= MAX_SUPPORTED_CONSENSUS_METHOD);
} }
@ -1455,11 +1448,7 @@ networkstatus_compute_consensus(smartlist_t *votes,
n_versioning_servers); n_versioning_servers);
client_versions = compute_consensus_versions_list(combined_client_versions, client_versions = compute_consensus_versions_list(combined_client_versions,
n_versioning_clients); n_versioning_clients);
if (consensus_method >= MIN_METHOD_FOR_PACKAGE_LINES) { packages = compute_consensus_package_lines(votes);
packages = compute_consensus_package_lines(votes);
} else {
packages = tor_strdup("");
}
SMARTLIST_FOREACH(combined_server_versions, char *, cp, tor_free(cp)); SMARTLIST_FOREACH(combined_server_versions, char *, cp, tor_free(cp));
SMARTLIST_FOREACH(combined_client_versions, char *, cp, tor_free(cp)); SMARTLIST_FOREACH(combined_client_versions, char *, cp, tor_free(cp));
@ -1971,8 +1960,7 @@ networkstatus_compute_consensus(smartlist_t *votes,
/* If it's a guard and we have enough guardfraction votes, /* If it's a guard and we have enough guardfraction votes,
calculate its consensus guardfraction value. */ calculate its consensus guardfraction value. */
if (is_guard && num_guardfraction_inputs > 2 && if (is_guard && num_guardfraction_inputs > 2) {
consensus_method >= MIN_METHOD_FOR_GUARDFRACTION) {
rs_out.has_guardfraction = 1; rs_out.has_guardfraction = 1;
rs_out.guardfraction_percentage = median_uint32(measured_guardfraction, rs_out.guardfraction_percentage = median_uint32(measured_guardfraction,
num_guardfraction_inputs); num_guardfraction_inputs);
@ -3865,8 +3853,7 @@ dirvote_create_microdescriptor(const routerinfo_t *ri, int consensus_method)
{ {
char idbuf[ED25519_BASE64_LEN+1]; char idbuf[ED25519_BASE64_LEN+1];
const char *keytype; const char *keytype;
if (consensus_method >= MIN_METHOD_FOR_ED25519_ID_IN_MD && if (ri->cache_info.signing_key_cert &&
ri->cache_info.signing_key_cert &&
ri->cache_info.signing_key_cert->signing_key_included) { ri->cache_info.signing_key_cert->signing_key_included) {
keytype = "ed25519"; keytype = "ed25519";
ed25519_public_to_base64(idbuf, ed25519_public_to_base64(idbuf,

12
src/or/dirvote.h
View File

@ -61,18 +61,6 @@
/** The highest consensus method that we currently support. */ /** The highest consensus method that we currently support. */
#define MAX_SUPPORTED_CONSENSUS_METHOD 28 #define MAX_SUPPORTED_CONSENSUS_METHOD 28
/** Lowest consensus method where we include "package" lines*/
#define MIN_METHOD_FOR_PACKAGE_LINES 19
/** Lowest consensus method where authorities may include
* GuardFraction information in microdescriptors. */
#define MIN_METHOD_FOR_GUARDFRACTION 20
/** Lowest consensus method where authorities may include an "id" line for
* ed25519 identities in microdescriptors. (Broken; see
* consensus_method_is_supported() for more info.) */
#define MIN_METHOD_FOR_ED25519_ID_IN_MD 21
/** Lowest consensus method where authorities vote on ed25519 ids and ensure /** Lowest consensus method where authorities vote on ed25519 ids and ensure
* ed25519 id consistency. */ * ed25519 id consistency. */
#define MIN_METHOD_FOR_ED25519_ID_VOTING 22 #define MIN_METHOD_FOR_ED25519_ID_VOTING 22

15
src/test/test_microdesc.c
View File

@ -396,16 +396,6 @@ static const char test_md_18[] =
"p reject 25,119,135-139,445,563,1214,4661-4666,6346-6429,6699,6881-6999\n" "p reject 25,119,135-139,445,563,1214,4661-4666,6346-6429,6699,6881-6999\n"
"id rsa1024 Cd47okjCHD83YGzThGBDptXs9Z4\n"; "id rsa1024 Cd47okjCHD83YGzThGBDptXs9Z4\n";
static const char test_md2_18[] =
"onion-key\n"
"-----BEGIN RSA PUBLIC KEY-----\n"
"MIGJAoGBAL2R8EfubUcahxha4u02P4VAR0llQIMwFAmrHPjzcK7apcQgDOf2ovOA\n"
"+YQnJFxlpBmCoCZC6ssCi+9G0mqo650lFuTMP5I90BdtjotfzESfTykHLiChyvhd\n"
"l0dlqclb2SU/GKem/fLRXH16aNi72CdSUu/1slKs/70ILi34QixRAgMBAAE=\n"
"-----END RSA PUBLIC KEY-----\n"
"ntor-onion-key hbxdRnfVUJJY7+KcT4E3Rs7/zuClbN3hJrjSBiEGMgI=\n"
"id rsa1024 t+J/EEITw28T5+mCkYKEXklZl6A\n";
static const char test_md2_21[] = static const char test_md2_21[] =
"onion-key\n" "onion-key\n"
"-----BEGIN RSA PUBLIC KEY-----\n" "-----BEGIN RSA PUBLIC KEY-----\n"
@ -439,11 +429,6 @@ test_md_generate(void *arg)
routerinfo_free(ri); routerinfo_free(ri);
ri = router_parse_entry_from_string(test_ri2, NULL, 0, 0, NULL, NULL); ri = router_parse_entry_from_string(test_ri2, NULL, 0, 0, NULL, NULL);
microdesc_free(md);
md = NULL;
md = dirvote_create_microdescriptor(ri, 18);
tt_str_op(md->body, OP_EQ, test_md2_18);
microdesc_free(md); microdesc_free(md);
md = NULL; md = NULL;
md = dirvote_create_microdescriptor(ri, 21); md = dirvote_create_microdescriptor(ri, 21);