nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Note some large functions that could be split.

Browse Source 
George Kadianakis pointed these out.
This commit is contained in:
Nick Mathewson 2016-11-29 11:34:37 -05:00
parent 3bcbbea350
commit 46619ec914
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/or/entrynodes.c
View File

@ -1099,6 +1099,7 @@ entry_guard_is_listed(guard_selection_t *gs, const entry_guard_t *guard)
STATIC void STATIC void
sampled_guards_update_from_consensus(guard_selection_t *gs) sampled_guards_update_from_consensus(guard_selection_t *gs)
{ {
/*XXXX prop271 consider splitting this function up. */
tor_assert(gs); tor_assert(gs);
const int REMOVE_UNLISTED_GUARDS_AFTER = const int REMOVE_UNLISTED_GUARDS_AFTER =
(get_remove_unlisted_guards_after_days() * 86400); (get_remove_unlisted_guards_after_days() * 86400);
@ -1503,6 +1504,7 @@ make_guard_confirmed(guard_selection_t *gs, entry_guard_t *guard)
STATIC void STATIC void
entry_guards_update_primary(guard_selection_t *gs) entry_guards_update_primary(guard_selection_t *gs)
{ {
/*XXXX prop271 consider splitting this function up. */
tor_assert(gs); tor_assert(gs);
// prevent recursion. Recursion is potentially very bad here. // prevent recursion. Recursion is potentially very bad here.
@ -1697,6 +1699,7 @@ entry_guards_note_internet_connectivity(guard_selection_t *gs)
STATIC entry_guard_t * STATIC entry_guard_t *
select_entry_guard_for_circuit(guard_selection_t *gs, unsigned *state_out) select_entry_guard_for_circuit(guard_selection_t *gs, unsigned *state_out)
{ {
/*XXXX prop271 consider splitting this function up. */
tor_assert(gs); tor_assert(gs);
tor_assert(state_out); tor_assert(state_out);