Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version()

This commit is contained in:
Neel Chauhan 2019-12-05 19:06:35 -05:00 committed by Nick Mathewson
parent 8933c7908d
commit 460b97380b
2 changed files with 14 additions and 11 deletions

4
changes/ticket32672 Normal file
View File

@ -0,0 +1,4 @@
o Minor features (directory authorities):
- Directory authorities now reject descriptors from relays running Tor
versions from the 0.2.9 and 0.4.0 series, but still allow the 0.3.5
series. Resolves ticket 32672. Patch by Neel Chauhan.

View File

@ -326,22 +326,21 @@ dirserv_rejects_tor_version(const char *platform,
static const char please_upgrade_string[] = static const char please_upgrade_string[] =
"Tor version is insecure or unsupported. Please upgrade!"; "Tor version is insecure or unsupported. Please upgrade!";
/* Versions before Tor 0.2.9 are unsupported. Versions between 0.2.9.0 and /* Versions before Tor 0.3.5 are unsupported.
* 0.2.9.4 suffer from bug #20499, where relays don't keep their consensus *
* up to date */ * Also, reject unstable versions of 0.3.5, since (as of this writing)
if (!tor_version_as_new_as(platform,"0.2.9.5-alpha")) { * they are almost none of the network. */
if (!tor_version_as_new_as(platform,"0.3.5.7")) {
if (msg) if (msg)
*msg = please_upgrade_string; *msg = please_upgrade_string;
return true; return true;
} }
/* Series between Tor 0.3.0 and 0.3.4 inclusive are unsupported, and some /* Series between Tor 0.3.6 and 0.4.1.4-rc inclusive are unsupported.
* have bug #27841, which makes them broken as intro points. Reject them. * Reject them. 0.3.6.0-alpha-dev only existed for a short time, before
* * it was renamed to 0.4.0.0-alpha-dev. */
* Also reject unstable versions of 0.3.5, since (as of this writing) if (tor_version_as_new_as(platform,"0.3.6.0-alpha-dev") &&
* they are almost none of the network. */ !tor_version_as_new_as(platform,"0.4.1.5")) {
if (tor_version_as_new_as(platform,"0.3.0.0-alpha-dev") &&
!tor_version_as_new_as(platform,"0.3.5.7")) {
if (msg) { if (msg) {
*msg = please_upgrade_string; *msg = please_upgrade_string;
} }