mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-28 06:13:31 +01:00
Fix some checks of tor_inet_ntoa() return value
Also, fix a format string.
This commit is contained in:
parent
7a004fce8d
commit
3e4814edeb
@ -1881,7 +1881,7 @@ evdns_wildcard_check_callback(int result, char type, int count, int ttl,
|
||||
int ntoa_res;
|
||||
in.s_addr = addrs[i];
|
||||
ntoa_res = tor_inet_ntoa(&in, answer_buf, sizeof(answer_buf));
|
||||
tor_assert_nonfatal(ntoa_res > 0);
|
||||
tor_assert_nonfatal(ntoa_res >= 0);
|
||||
if (ntoa_res > 0)
|
||||
wildcard_increment_answer(answer_buf);
|
||||
}
|
||||
|
@ -1207,10 +1207,10 @@ fmt_addr32(uint32_t addr)
|
||||
in.s_addr = htonl(addr);
|
||||
|
||||
success = tor_inet_ntoa(&in, buf, sizeof(buf));
|
||||
tor_assertf_nonfatal(success > 0,
|
||||
"Failed to convert IP %04X to string", addr);
|
||||
tor_assertf_nonfatal(success >= 0,
|
||||
"Failed to convert IP 0x%08X (HBO) to string", addr);
|
||||
|
||||
if (success <= 0) {
|
||||
IF_BUG_ONCE(success < 0) {
|
||||
memset(buf, 0, INET_NTOA_BUF_LEN);
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user