nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Downgrade a PROTOCOL_WARN log message.

Browse Source 
This one happens every time we get a failure from
circuit_receive_relay_cell -- but for all the relevant failing cases
in that function, we already log in that function.

This resolves one case of #40400.  Two cases remain.
This commit is contained in:
Nick Mathewson 2021-10-13 16:51:46 -04:00
parent ba5a71b913
commit 3da455de00
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
changes/bug40400 Normal file
View File

@ -0,0 +1,6 @@
o Minor bugfixes (usability):
- Do not log "circuit_receive_relay_cell failed" at LOG_PROTOCOL_WARN;
instead log it at DEBUG. In every case where we would want to log
this as a protocol warning, we are already logging another warning
from inside circuit_receive_relay_cell. Fixes part of bug 40400;
bugfix on 0.1.1.9.

2
src/core/or/command.c
View File

@ -563,7 +563,7 @@ command_process_relay_cell(cell_t *cell, channel_t *chan)
} }
if ((reason = circuit_receive_relay_cell(cell, circ, direction)) < 0) { if ((reason = circuit_receive_relay_cell(cell, circ, direction)) < 0) {
log_fn(LOG_PROTOCOL_WARN,LD_PROTOCOL,"circuit_receive_relay_cell " log_fn(LOG_DEBUG,LD_PROTOCOL,"circuit_receive_relay_cell "
"(%s) failed. Closing.", "(%s) failed. Closing.",
direction==CELL_DIRECTION_OUT?"forward":"backward"); direction==CELL_DIRECTION_OUT?"forward":"backward");
/* Always emit a bandwidth event for closed circs */ /* Always emit a bandwidth event for closed circs */