nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Downgrade "Bug: No entry found in extrainfo map" message.

Browse Source 
This is not actually a bug!  It can happen for a bunch of reasons,
which all boil down to "trying to add an extrainfo for which we no
longer have the corresponding routerinfo".

Fixes #16016; bugfix on 0.2.6.3-alpha.
This commit is contained in:
Nick Mathewson 2020-06-30 11:54:13 -04:00
parent 8697205be4
commit 39830b6408
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
changes/bug16016 Normal file
View File

@ -0,0 +1,4 @@
o Minor bugfixes (logging):
- Downgrade a noisy log message that could occur naturally when
receiving an extrainfo document that we no longer want.
Fixes bug 16016; bugfix on 0.2.6.3-alpha.

6
src/feature/nodelist/routerlist.c
View File

@ -1087,7 +1087,11 @@ extrainfo_insert,(routerlist_t *rl, extrainfo_t *ei, int warn_if_incompatible))
* This just won't work. */; * This just won't work. */;
static ratelim_t no_sd_ratelim = RATELIM_INIT(1800); static ratelim_t no_sd_ratelim = RATELIM_INIT(1800);
r = ROUTER_BAD_EI; r = ROUTER_BAD_EI;
log_fn_ratelim(&no_sd_ratelim, severity, LD_BUG, /* This is a DEBUG because it can happen naturally, if we tried
* to add an extrainfo for which we no longer have the
* corresponding routerinfo.
*/
log_fn_ratelim(&no_sd_ratelim, LOG_DEBUG, LD_DIR,
"No entry found in extrainfo map."); "No entry found in extrainfo map.");
goto done; goto done;
} }