nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 21:23:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix additional leaks in #22103 tests

Browse Source 
test_options_validate_impl() incorrectly executed subsequent phases of
config parsing and validation after an expected error.  This caused
msg to leak when those later phases (which would likely produce errors
as well) overwrote it.
This commit is contained in:
Taylor Yu 2017-05-03 13:08:32 -04:00
parent 77d9dd39c3
commit 38a13b91a8
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/test_options.c
View File

@ -187,6 +187,8 @@ test_options_validate_impl(const char *configuration,
goto done;
}
tt_int_op((r == 0), OP_EQ, (msg == NULL));
if (r)
goto done;
r = config_assign(&options_format, opt, cl, 0, &msg);
if (phase == PH_ASSIGN) {
@ -196,6 +198,8 @@ test_options_validate_impl(const char *configuration,
goto done;
}
tt_int_op((r == 0), OP_EQ, (msg == NULL));
if (r)
goto done;
r = options_validate(NULL, opt, dflt, 0, &msg);
if (phase == PH_VALIDATE) {