nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-12-03 17:13:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Resume expanding abbreviations for command-line options

Browse Source 
The fix for bug 4647 accidentally removed our hack from bug 586 that
rewrote HashedControlPassword to __HashedControlSessionPassword when
it appears on the commandline (which allowed the user to set her own
HashedControlPassword in the torrc file while the controller generates
a fresh session password for each run).

Fixes bug 12948; bugfix on 0.2.5.1-alpha.
This commit is contained in:
Roger Dingledine 2014-08-27 06:10:35 -04:00 committed by Nick Mathewson
parent b159ffb675
commit 37a76d75dd
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
changes/bug12948 Normal file
View File

@ -0,0 +1,8 @@
o Major bugfixes:
- Resume expanding abbreviations for command-line options. The fix
for bug 4647 accidentally removed our hack from bug 586 that rewrote
HashedControlPassword to __HashedControlSessionPassword when it
appears on the commandline (which allowed the user to set her
own HashedControlPassword in the torrc file while the controller
generates a fresh session password for each run). Fixes bug 12948;
bugfix on 0.2.5.1-alpha.

3
src/or/config.c
View File

@ -1932,7 +1932,8 @@ config_parse_commandline(int argc, char **argv, int ignore_errors,
} }
param = tor_malloc_zero(sizeof(config_line_t)); param = tor_malloc_zero(sizeof(config_line_t));
param->key = is_cmdline ? tor_strdup(argv[i]) : tor_strdup(s); param->key = is_cmdline ? tor_strdup(argv[i]) :
tor_strdup(config_expand_abbrev(&options_format, s, 1, 1));
param->value = arg; param->value = arg;
param->command = command; param->command = command;
param->next = NULL; param->next = NULL;