nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-21 05:26:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fail if file is too large to mmap.

Browse Source 
If tor_mmap_file is called with a file which is larger than SIZE_MAX,
only a small part of the file will be memory-mapped due to integer
truncation.

This can only realistically happen on 32 bit architectures with large
file support.
This commit is contained in:
junglefowl 2017-01-23 19:08:54 +00:00 committed by Nick Mathewson
parent 1130fd87ed
commit 373d9aff7a
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changes/bug21134 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (portability):
- Do not silently truncate content of files if they are larger
than SIZE_MAX bytes. This issue could occur on 32 bit systems
with large file support and files which are larger than 4 GB.
Fixes bug 21134; bugfix on 0.3.0.1-alpha.

6
src/common/compat.c
View File

@ -258,6 +258,12 @@ tor_mmap_file(const char *filename)
page_size = getpagesize();
size += (size%page_size) ? page_size-(size%page_size) : 0;
if (st.st_size > SSIZE_T_CEILING || size < st.st_size) {
log_warn(LD_FS, "File \"%s\" is too large. Ignoring.",filename);
errno = EFBIG;
close(fd);
return NULL;
}
if (!size) {
/* Zero-length file. If we call mmap on it, it will succeed but
* return NULL, and bad things will happen. So just fail. */