mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-10 13:13:44 +01:00
Merge branch 'tor-gitlab/mr/636'
This commit is contained in:
commit
3596d193be
3
changes/ticket40691
Normal file
3
changes/ticket40691
Normal file
@ -0,0 +1,3 @@
|
||||
o Minor features (relay):
|
||||
- Do not warn about configuration options that may expose a non-anonymous
|
||||
onion service. Closes ticket 40691.
|
@ -33,6 +33,7 @@
|
||||
#include "core/or/port_cfg_st.h"
|
||||
|
||||
#include "feature/hibernate/hibernate.h"
|
||||
#include "feature/hs/hs_service.h"
|
||||
#include "feature/nodelist/nickname.h"
|
||||
#include "feature/stats/geoip_stats.h"
|
||||
#include "feature/stats/predict_ports.h"
|
||||
@ -942,7 +943,8 @@ options_validate_relay_accounting(const or_options_t *old_options,
|
||||
if (accounting_parse_options(options, 1)<0)
|
||||
REJECT("Failed to parse accounting options. See logs for details.");
|
||||
|
||||
if (options->AccountingMax) {
|
||||
if (options->AccountingMax &&
|
||||
!hs_service_non_anonymous_mode_enabled(options)) {
|
||||
if (options->RendConfigLines && server_mode(options)) {
|
||||
log_warn(LD_CONFIG, "Using accounting with a hidden service and an "
|
||||
"ORPort is risky: your hidden service(s) and your public "
|
||||
@ -1118,7 +1120,8 @@ options_validate_relay_mode(const or_options_t *old_options,
|
||||
if (BUG(!msg))
|
||||
return -1;
|
||||
|
||||
if (server_mode(options) && options->RendConfigLines)
|
||||
if (server_mode(options) && options->RendConfigLines &&
|
||||
!hs_service_non_anonymous_mode_enabled(options))
|
||||
log_warn(LD_CONFIG,
|
||||
"Tor is currently configured as a relay and a hidden service. "
|
||||
"That's not very secure: you should probably run your hidden service "
|
||||
|
Loading…
Reference in New Issue
Block a user