nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-21 05:26:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change a silent ignore-the-bug in microdesc.c to a LOG_INFO

Browse Source 
I don't believe this bug occurs, but there was an XXX023 to make
sure it doesn't.
This commit is contained in:
Nick Mathewson 2012-06-15 10:40:37 -04:00
parent e62104a7d2
commit 32bf258881
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changes/log_bad_md_entry Normal file
View File

@ -0,0 +1,3 @@
o Minor features (debugging):
- Log a BUG message at INFO if we have a networkstatus with a missing
entry for some microdescriptor.

9
src/or/microdesc.c
View File

@ -643,8 +643,13 @@ microdesc_list_missing_digest256(networkstatus_t *ns, microdesc_cache_t *cache,
continue;
if (skip && digestmap_get(skip, rs->descriptor_digest))
continue;
if (tor_mem_is_zero(rs->descriptor_digest, DIGEST256_LEN))
continue; /* This indicates a bug somewhere XXXX023*/
if (tor_mem_is_zero(rs->descriptor_digest, DIGEST256_LEN)) {
log_info(LD_BUG, "Found an entry in networktatus with no microdescriptor "
"digest. (Router %s=%s at %s:%d.)", rs->nickname,
hex_str(rs->identity_digest, DIGEST_LEN),
fmt_addr32(rs->addr), rs->or_port);
continue;
}
/* XXXX Also skip if we're a noncache and wouldn't use this router.
* XXXX NM Microdesc
*/