Increase the minimum value for the Fast flag to 4096.

Fix for 8145.
This commit is contained in:
Nick Mathewson 2013-02-04 10:41:11 -05:00
parent 8be7f69f8d
commit 317d16de04
2 changed files with 7 additions and 2 deletions

View File

@ -3,3 +3,5 @@
nodes during the computation so that they can't influence Fast, nodes during the computation so that they can't influence Fast,
Guard, etc. Fixes bug 8146. Guard, etc. Fixes bug 8146.
- When computing thresholds for flags, never let the threshold for
the Fast flag to 4096 bytes. Fixes bug 8145.

View File

@ -1986,9 +1986,12 @@ dirserv_compute_performance_thresholds(routerlist_t *rl,
{ {
/* We can vote on a parameter for the minimum and maximum. */ /* We can vote on a parameter for the minimum and maximum. */
#define ABSOLUTE_MIN_VALUE_FOR_FAST_FLAG 4096
int32_t min_fast, max_fast; int32_t min_fast, max_fast;
min_fast = networkstatus_get_param(NULL, "FastFlagMinThreshold", min_fast = networkstatus_get_param(NULL, "FastFlagMinThreshold",
0, 0, INT32_MAX); ABSOLUTE_MIN_VALUE_FOR_FAST_FLAG,
ABSOLUTE_MIN_VALUE_FOR_FAST_FLAG,
INT32_MAX);
max_fast = networkstatus_get_param(NULL, "FastFlagMaxThreshold", max_fast = networkstatus_get_param(NULL, "FastFlagMaxThreshold",
INT32_MAX, min_fast, INT32_MAX); INT32_MAX, min_fast, INT32_MAX);
if (fast_bandwidth < (uint32_t)min_fast) if (fast_bandwidth < (uint32_t)min_fast)