nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

backtrace: avoid undefined behaviour on re-initialisation

Browse Source 
cb_buf_mutex is statically initialised, so we can not destroy it when
we are shutting down the err subsystem. If we destroy it, and then
re-initialise tor, all our backtraces will fail.

Part of 31736, but committed in this branch to avoid merge conflicts.
This commit is contained in:
teor 2019-09-20 11:40:05 +10:00
parent ab7bfdf404
commit 315f14c709
No known key found for this signature in database
GPG Key ID: 10FEAA0E7075672A
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/err/backtrace.c
View File

@ -251,6 +251,10 @@ remove_bt_handler(void)
* It's not a fatal error, so we just ignore it. */ * It's not a fatal error, so we just ignore it. */
(void)sigaction(trap_signals[i], &sa, NULL); (void)sigaction(trap_signals[i], &sa, NULL);
} }
/* cb_buf_mutex is statically initialised, so we can not destroy it.
* If we destroy it, and then re-initialise tor, all our backtraces will
* fail. */
} }
#endif /* defined(USE_BACKTRACE) */ #endif /* defined(USE_BACKTRACE) */