mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-28 14:23:30 +01:00
Fix tests to use the new design.
- All histogram tests were using start_usec/range_usec. We now manually specify the edges. - Also add a test for histogram_get_bin_upper_bound().
This commit is contained in:
parent
80abe4170d
commit
3093d8afbe
@ -2086,13 +2086,15 @@ circpad_circ_client_machine_init(void)
|
||||
|
||||
// FIXME: Tune this histogram
|
||||
circ_client_machine->states[CIRCPAD_STATE_BURST].histogram_len = 2;
|
||||
circ_client_machine->states[CIRCPAD_STATE_BURST].start_usec = 500;
|
||||
circ_client_machine->states[CIRCPAD_STATE_BURST].range_usec = 1000000;
|
||||
circ_client_machine->states[CIRCPAD_STATE_BURST].histogram_edges[0]= 500;
|
||||
circ_client_machine->states[CIRCPAD_STATE_BURST].histogram_edges[1]= 1000000;
|
||||
|
||||
/* We have 5 tokens in the histogram, which means that all circuits will look
|
||||
* like they have 7 hops (since we start this machine after the second hop,
|
||||
* and tokens are decremented for any valid hops, and fake extends are
|
||||
* used after that -- 2+5==7). */
|
||||
circ_client_machine->states[CIRCPAD_STATE_BURST].histogram[0] = 5;
|
||||
|
||||
circ_client_machine->states[CIRCPAD_STATE_BURST].histogram_total_tokens = 5;
|
||||
|
||||
circ_client_machine->machine_num = smartlist_len(origin_padding_machines);
|
||||
@ -2143,8 +2145,9 @@ circpad_circ_responder_machine_init(void)
|
||||
circ_responder_machine->states[CIRCPAD_STATE_BURST].use_rtt_estimate = 1;
|
||||
/* The histogram is 2 bins: an empty one, and infinity */
|
||||
circ_responder_machine->states[CIRCPAD_STATE_BURST].histogram_len = 2;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_BURST].start_usec = 5000;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_BURST].range_usec = 1000000;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_BURST].histogram_edges[0]= 500;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_BURST].histogram_edges[1] =
|
||||
1000000;
|
||||
/* During burst state we wait forever for padding to arrive.
|
||||
|
||||
We are waiting for a padding cell from the client to come in, so that we
|
||||
@ -2175,8 +2178,15 @@ circpad_circ_responder_machine_init(void)
|
||||
before you send a padding response */
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].use_rtt_estimate = 1;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_len = 6;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].start_usec = 5000;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].range_usec = 1000000;
|
||||
/* Specify histogram bins */
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_edges[0]= 500;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_edges[1]= 1000;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_edges[2]= 2000;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_edges[3]= 4000;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_edges[4]= 8000;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_edges[5]= 16000;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_edges[6]=1000000;
|
||||
/* Specify histogram tokens */
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram[0] = 0;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram[1] = 1;
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram[2] = 2;
|
||||
@ -2184,6 +2194,7 @@ circpad_circ_responder_machine_init(void)
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram[4] = 1;
|
||||
/* Total number of tokens */
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].histogram_total_tokens = 6;
|
||||
|
||||
circ_responder_machine->states[CIRCPAD_STATE_GAP].token_removal =
|
||||
CIRCPAD_TOKEN_REMOVAL_CLOSEST_USEC;
|
||||
|
||||
|
@ -334,7 +334,7 @@ test_circuitpadding_rtt(void *arg)
|
||||
OP_EQ,
|
||||
relay_side->padding_info[0]->rtt_estimate_usec+
|
||||
circpad_machine_current_state(
|
||||
relay_side->padding_info[0])->start_usec);
|
||||
relay_side->padding_info[0])->histogram_edges[0]);
|
||||
|
||||
circpad_cell_event_nonpadding_received((circuit_t*)relay_side);
|
||||
circpad_cell_event_nonpadding_received((circuit_t*)relay_side);
|
||||
@ -350,7 +350,7 @@ test_circuitpadding_rtt(void *arg)
|
||||
OP_EQ,
|
||||
relay_side->padding_info[0]->rtt_estimate_usec+
|
||||
circpad_machine_current_state(
|
||||
relay_side->padding_info[0])->start_usec);
|
||||
relay_side->padding_info[0])->histogram_edges[0]);
|
||||
|
||||
/* Test 2: Termination of RTT measurement (from the previous test) */
|
||||
tt_int_op(relay_side->padding_info[0]->stop_rtt_update, OP_EQ, 1);
|
||||
@ -368,7 +368,7 @@ test_circuitpadding_rtt(void *arg)
|
||||
OP_EQ,
|
||||
relay_side->padding_info[0]->rtt_estimate_usec+
|
||||
circpad_machine_current_state(
|
||||
relay_side->padding_info[0])->start_usec);
|
||||
relay_side->padding_info[0])->histogram_edges[0]);
|
||||
|
||||
/* Test 3: Make sure client side machine properly ignores RTT */
|
||||
circpad_cell_event_nonpadding_received((circuit_t*)client_side);
|
||||
@ -384,7 +384,7 @@ test_circuitpadding_rtt(void *arg)
|
||||
tt_int_op(circpad_histogram_bin_to_usec(client_side->padding_info[0], 0),
|
||||
OP_EQ,
|
||||
circpad_machine_current_state(
|
||||
client_side->padding_info[0])->start_usec);
|
||||
client_side->padding_info[0])->histogram_edges[0]);
|
||||
done:
|
||||
free_fake_orcirc(relay_side);
|
||||
circuitmux_detach_all_circuits(dummy_channel.cmux, NULL);
|
||||
@ -415,19 +415,25 @@ helper_create_basic_machine(void)
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].
|
||||
next_state[CIRCPAD_EVENT_NONPADDING_SENT] = CIRCPAD_STATE_CANCEL;
|
||||
|
||||
// FIXME: Is this what we want?
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].token_removal =
|
||||
CIRCPAD_TOKEN_REMOVAL_HIGHER;
|
||||
|
||||
// FIXME: Tune this histogram
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_len = 5;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].start_usec = 500;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].range_usec = 1000000;
|
||||
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[0] = 500;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[1] = 2500;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[2] = 5000;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[3] = 10000;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[4] = 20000;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[5] = 400000;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[6] = 1000000;
|
||||
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram[0] = 1;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram[1] = 0;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram[2] = 2;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram[3] = 2;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram[4] = 2;
|
||||
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_total_tokens = 7;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].use_rtt_estimate = 1;
|
||||
|
||||
@ -459,15 +465,25 @@ helper_create_machine_with_big_histogram(circpad_removal_t removal_strategy)
|
||||
burst_state->token_removal = CIRCPAD_TOKEN_REMOVAL_HIGHER;
|
||||
|
||||
burst_state->histogram_len = BIG_HISTOGRAM_LEN;
|
||||
burst_state->start_usec = 0;
|
||||
burst_state->range_usec = 1000;
|
||||
|
||||
int n_tokens = 0;
|
||||
for (int i = 0; i < BIG_HISTOGRAM_LEN ; i++) {
|
||||
int i;
|
||||
for (i = 0; i < BIG_HISTOGRAM_LEN ; i++) {
|
||||
burst_state->histogram[i] = tokens_per_bin;
|
||||
n_tokens += tokens_per_bin;
|
||||
}
|
||||
|
||||
burst_state->histogram_edges[0] = 0;
|
||||
burst_state->histogram_edges[1] = 1;
|
||||
burst_state->histogram_edges[2] = 7;
|
||||
burst_state->histogram_edges[3] = 15;
|
||||
burst_state->histogram_edges[4] = 31;
|
||||
burst_state->histogram_edges[5] = 62;
|
||||
burst_state->histogram_edges[6] = 125;
|
||||
burst_state->histogram_edges[7] = 250;
|
||||
burst_state->histogram_edges[8] = 500;
|
||||
burst_state->histogram_edges[9] = 1000;
|
||||
|
||||
burst_state->histogram_total_tokens = n_tokens;
|
||||
burst_state->length_dist.type = CIRCPAD_DIST_UNIFORM;
|
||||
burst_state->length_dist.param1 = n_tokens;
|
||||
@ -528,12 +544,20 @@ test_circuitpadding_token_removal_higher(void *arg)
|
||||
|
||||
/* Test left boundaries of each histogram bin: */
|
||||
const circpad_delay_t bin_left_bounds[] =
|
||||
{0, 1, 7, 15, 31, 62, 125, 250, 500, CIRCPAD_DELAY_INFINITE};
|
||||
for (int i = 0; i < BIG_HISTOGRAM_LEN ; i++) {
|
||||
{0, 1, 7, 15, 31, 62, 125, 250, 500, 1000, CIRCPAD_DELAY_INFINITE};
|
||||
for (int i = 0; i <= BIG_HISTOGRAM_LEN ; i++) {
|
||||
tt_uint_op(bin_left_bounds[i], OP_EQ,
|
||||
circpad_histogram_bin_to_usec(mi, i));
|
||||
}
|
||||
|
||||
/* Test right boundaries of each histogram bin: */
|
||||
const circpad_delay_t bin_right_bounds[] =
|
||||
{0, 6, 14, 30, 61, 124, 249, 499, 999, CIRCPAD_DELAY_INFINITE-1};
|
||||
for (int i = 0; i < BIG_HISTOGRAM_LEN ; i++) {
|
||||
tt_uint_op(bin_right_bounds[i], OP_EQ,
|
||||
histogram_get_bin_upper_bound(mi, i));
|
||||
}
|
||||
|
||||
/* Check that all bins have two tokens right now */
|
||||
for (int i = 0; i < BIG_HISTOGRAM_LEN ; i++) {
|
||||
tt_int_op(mi->histogram[i], OP_EQ, 2);
|
||||
@ -577,8 +601,8 @@ test_circuitpadding_token_removal_higher(void *arg)
|
||||
/* Test below the lowest bin, for coverage */
|
||||
tt_int_op(client_side->padding_info[0]->current_state, OP_EQ,
|
||||
CIRCPAD_STATE_BURST);
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].start_usec = 100;
|
||||
mi->padding_scheduled_at_usec = current_time - 1;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[0] = 100;
|
||||
mi->padding_scheduled_at_usec = current_time;
|
||||
circpad_machine_remove_token(mi);
|
||||
tt_int_op(mi->histogram[0], OP_EQ, 1);
|
||||
|
||||
@ -625,8 +649,8 @@ test_circuitpadding_token_removal_lower(void *arg)
|
||||
|
||||
/* Test left boundaries of each histogram bin: */
|
||||
const circpad_delay_t bin_left_bounds[] =
|
||||
{0, 1, 7, 15, 31, 62, 125, 250, 500, CIRCPAD_DELAY_INFINITE};
|
||||
for (int i = 0; i < BIG_HISTOGRAM_LEN ; i++) {
|
||||
{0, 1, 7, 15, 31, 62, 125, 250, 500, 1000, CIRCPAD_DELAY_INFINITE};
|
||||
for (int i = 0; i <= BIG_HISTOGRAM_LEN ; i++) {
|
||||
tt_uint_op(bin_left_bounds[i], OP_EQ,
|
||||
circpad_histogram_bin_to_usec(mi, i));
|
||||
}
|
||||
@ -674,7 +698,8 @@ test_circuitpadding_token_removal_lower(void *arg)
|
||||
/* Test above the highest bin, for coverage */
|
||||
tt_int_op(client_side->padding_info[0]->current_state, OP_EQ,
|
||||
CIRCPAD_STATE_BURST);
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].start_usec = 100;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].
|
||||
histogram_edges[BIG_HISTOGRAM_LEN-2] = 100;
|
||||
mi->padding_scheduled_at_usec = current_time - 29202;
|
||||
circpad_machine_remove_token(mi);
|
||||
tt_int_op(mi->histogram[BIG_HISTOGRAM_LEN-2], OP_EQ, 1);
|
||||
@ -722,8 +747,8 @@ test_circuitpadding_closest_token_removal(void *arg)
|
||||
|
||||
/* Test left boundaries of each histogram bin: */
|
||||
const circpad_delay_t bin_left_bounds[] =
|
||||
{0, 1, 7, 15, 31, 62, 125, 250, 500, CIRCPAD_DELAY_INFINITE};
|
||||
for (int i = 0; i < BIG_HISTOGRAM_LEN ; i++) {
|
||||
{0, 1, 7, 15, 31, 62, 125, 250, 500, 1000, CIRCPAD_DELAY_INFINITE};
|
||||
for (int i = 0; i <= BIG_HISTOGRAM_LEN ; i++) {
|
||||
tt_uint_op(bin_left_bounds[i], OP_EQ,
|
||||
circpad_histogram_bin_to_usec(mi, i));
|
||||
}
|
||||
@ -770,7 +795,9 @@ test_circuitpadding_closest_token_removal(void *arg)
|
||||
/* Test below the lowest bin, for coverage */
|
||||
tt_int_op(client_side->padding_info[0]->current_state, OP_EQ,
|
||||
CIRCPAD_STATE_BURST);
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].start_usec = 100;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[0] = 100;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[1] = 100;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[2] = 120;
|
||||
mi->padding_scheduled_at_usec = current_time - 102;
|
||||
mi->histogram[0] = 0;
|
||||
circpad_machine_remove_token(mi);
|
||||
@ -779,7 +806,6 @@ test_circuitpadding_closest_token_removal(void *arg)
|
||||
/* Test above the highest bin, for coverage */
|
||||
tt_int_op(client_side->padding_info[0]->current_state, OP_EQ,
|
||||
CIRCPAD_STATE_BURST);
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].start_usec = 100;
|
||||
mi->padding_scheduled_at_usec = current_time - 29202;
|
||||
circpad_machine_remove_token(mi);
|
||||
tt_int_op(mi->histogram[BIG_HISTOGRAM_LEN-2], OP_EQ, 1);
|
||||
@ -827,8 +853,8 @@ test_circuitpadding_closest_token_removal_usec(void *arg)
|
||||
|
||||
/* Test left boundaries of each histogram bin: */
|
||||
const circpad_delay_t bin_left_bounds[] =
|
||||
{0, 1, 7, 15, 31, 62, 125, 250, 500, CIRCPAD_DELAY_INFINITE};
|
||||
for (int i = 0; i < BIG_HISTOGRAM_LEN ; i++) {
|
||||
{0, 1, 7, 15, 31, 62, 125, 250, 500, 1000, CIRCPAD_DELAY_INFINITE};
|
||||
for (int i = 0; i <= BIG_HISTOGRAM_LEN ; i++) {
|
||||
tt_uint_op(bin_left_bounds[i], OP_EQ,
|
||||
circpad_histogram_bin_to_usec(mi, i));
|
||||
}
|
||||
@ -878,7 +904,9 @@ test_circuitpadding_closest_token_removal_usec(void *arg)
|
||||
/* Test below the lowest bin, for coverage */
|
||||
tt_int_op(client_side->padding_info[0]->current_state, OP_EQ,
|
||||
CIRCPAD_STATE_BURST);
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].start_usec = 100;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[0] = 100;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[1] = 100;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].histogram_edges[2] = 120;
|
||||
mi->padding_scheduled_at_usec = current_time - 102;
|
||||
mi->histogram[0] = 0;
|
||||
circpad_machine_remove_token(mi);
|
||||
@ -887,7 +915,8 @@ test_circuitpadding_closest_token_removal_usec(void *arg)
|
||||
/* Test above the highest bin, for coverage */
|
||||
tt_int_op(client_side->padding_info[0]->current_state, OP_EQ,
|
||||
CIRCPAD_STATE_BURST);
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].start_usec = 100;
|
||||
circ_client_machine.states[CIRCPAD_STATE_BURST].
|
||||
histogram_edges[BIG_HISTOGRAM_LEN-2] = 100;
|
||||
mi->padding_scheduled_at_usec = current_time - 29202;
|
||||
circpad_machine_remove_token(mi);
|
||||
tt_int_op(mi->histogram[BIG_HISTOGRAM_LEN-2], OP_EQ, 1);
|
||||
@ -1044,7 +1073,7 @@ test_circuitpadding_tokens(void *arg)
|
||||
|
||||
// Test 1: converting usec->bin->usec->bin
|
||||
// Bin 0+1 have different semantics.
|
||||
for (circpad_delay_t i = 0; i <= state->start_usec+1; i++) {
|
||||
for (circpad_delay_t i = 0; i <= state->histogram_edges[0]; i++) {
|
||||
int bin = circpad_histogram_usec_to_bin(client_side->padding_info[0],
|
||||
i);
|
||||
circpad_delay_t usec =
|
||||
@ -1054,8 +1083,9 @@ test_circuitpadding_tokens(void *arg)
|
||||
tt_int_op(bin, OP_EQ, bin2);
|
||||
tt_int_op(i, OP_LE, usec);
|
||||
}
|
||||
for (circpad_delay_t i = state->start_usec+1;
|
||||
i <= state->start_usec + state->range_usec; i++) {
|
||||
for (circpad_delay_t i = state->histogram_edges[0]+1;
|
||||
i <= state->histogram_edges[0] +
|
||||
state->histogram_edges[state->histogram_len-2]; i++) {
|
||||
int bin = circpad_histogram_usec_to_bin(client_side->padding_info[0],
|
||||
i);
|
||||
circpad_delay_t usec =
|
||||
@ -1107,8 +1137,7 @@ test_circuitpadding_tokens(void *arg)
|
||||
/* 2.c. Bin 0 */
|
||||
{
|
||||
tt_int_op(mi->histogram[0], OP_EQ, 1);
|
||||
circpad_machine_remove_higher_token(mi,
|
||||
state->start_usec/2);
|
||||
circpad_machine_remove_higher_token(mi, state->histogram_edges[0]/2);
|
||||
tt_int_op(mi->histogram[0], OP_EQ, 0);
|
||||
}
|
||||
|
||||
@ -1127,8 +1156,7 @@ test_circuitpadding_tokens(void *arg)
|
||||
/* 3.a. Bin 0 */
|
||||
{
|
||||
tt_int_op(mi->histogram[0], OP_EQ, 1);
|
||||
circpad_machine_remove_higher_token(mi,
|
||||
state->start_usec/2);
|
||||
circpad_machine_remove_higher_token(mi, state->histogram_edges[0]/2);
|
||||
tt_int_op(mi->histogram[0], OP_EQ, 0);
|
||||
}
|
||||
|
||||
@ -1616,15 +1644,20 @@ helper_create_conditional_machine(void)
|
||||
ret->states[CIRCPAD_STATE_BURST].
|
||||
next_state[CIRCPAD_EVENT_LENGTH_COUNT] = CIRCPAD_STATE_END;
|
||||
|
||||
/* Use EXACT removal strategy, otherwise setup_tokens() does not work */
|
||||
ret->states[CIRCPAD_STATE_BURST].token_removal =
|
||||
CIRCPAD_TOKEN_REMOVAL_NONE;
|
||||
CIRCPAD_TOKEN_REMOVAL_EXACT;
|
||||
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram_len = 3;
|
||||
ret->states[CIRCPAD_STATE_BURST].start_usec = 0;
|
||||
ret->states[CIRCPAD_STATE_BURST].range_usec = 1000000;
|
||||
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram_edges[0] = 0;
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram_edges[1] = 0;
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram_edges[2] = 1000000;
|
||||
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram[0] = 6;
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram[1] = 0;
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram[1] = 0;
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram[2] = 0;
|
||||
|
||||
ret->states[CIRCPAD_STATE_BURST].histogram_total_tokens = 6;
|
||||
ret->states[CIRCPAD_STATE_BURST].use_rtt_estimate = 0;
|
||||
ret->states[CIRCPAD_STATE_BURST].length_includes_nonpadding = 1;
|
||||
|
Loading…
Reference in New Issue
Block a user