nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 12:23:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add comments to connection_check_event().

Browse Source
This commit is contained in:
Nick Mathewson 2016-03-14 12:53:21 -04:00
parent 91d7cf50c6
commit 307b863556
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/or/main.c
View File

@ -567,14 +567,24 @@ connection_is_reading(connection_t *conn)
(conn->read_event && event_pending(conn->read_event, EV_READ, NULL)); (conn->read_event && event_pending(conn->read_event, EV_READ, NULL));
} }
/** Check whether <b>conn</b> is correct in having (or not having) a
* read/write event (passed in <b>ev</b). On success, return 0. On failure,
* log a warning and return -1. */
static int static int
connection_check_event(connection_t *conn, struct event *ev) connection_check_event(connection_t *conn, struct event *ev)
{ {
int bad; int bad;
if (conn->type == CONN_TYPE_AP && TO_EDGE_CONN(conn)->is_dns_request) { if (conn->type == CONN_TYPE_AP && TO_EDGE_CONN(conn)->is_dns_request) {
/* DNS requests which we launch through the dnsserv.c module do not have
* any underlying socket or any underlying linked connection, so they
* shouldn't have any attached events either.
*/
bad = ev != NULL; bad = ev != NULL;
} else { } else {
/* Everytyhing else should have an underlying socket, or a linked
* connection (which is also tracked with a read_event/write_event pair).
*/
bad = ev == NULL; bad = ev == NULL;
} }