nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-13 06:33:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Report deleted consensuses as NOT_FOUND rather than AVAILABLE

Browse Source 
This bug happened because of a bogus pointer check in
consdiffmgr_find_consensus(), not in any released Tor.

Fixes CID 1409670.  Good catch, Coverity!
This commit is contained in:
Nick Mathewson 2017-05-16 10:44:24 -04:00
parent 222534d354
commit 2ca827104d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/or/consdiffmgr.c
View File

@ -577,7 +577,7 @@ consdiffmgr_find_consensus(struct consensus_cache_entry_t **entry_out,
if (!handle) if (!handle)
return CONSDIFF_NOT_FOUND; return CONSDIFF_NOT_FOUND;
*entry_out = consensus_cache_entry_handle_get(handle); *entry_out = consensus_cache_entry_handle_get(handle);
if (entry_out) if (*entry_out)
return CONSDIFF_AVAILABLE; return CONSDIFF_AVAILABLE;
else else
return CONSDIFF_NOT_FOUND; return CONSDIFF_NOT_FOUND;