nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 06:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix bug 245: When modifying the orconn_circid_map map, we would

Browse Source 
sometimes decrement conn->n_circuits even when there was no circuit
originally. This caused conn->n_circuits to go negative.

We noticed this because we were checking if connections can be
closed based on conn->n_circuits == 0, so we were never closing
any connection that had ever had a circuit on it.


svn:r5931
This commit is contained in:
Roger Dingledine 2006-02-09 02:42:15 +00:00
parent 1c596156aa
commit 2c221dd8db
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/or/circuitlist.c
View File

@ -112,8 +112,8 @@ circuit_set_circid_orconn(circuit_t *circ, uint16_t id,
found = HT_REMOVE(orconn_circid_map, &orconn_circid_circuit_map, &search); found = HT_REMOVE(orconn_circid_map, &orconn_circid_circuit_map, &search);
if (found) { if (found) {
tor_free(found); tor_free(found);
--old_conn->n_circuits;
} }
--old_conn->n_circuits;
} }
if (conn == NULL) if (conn == NULL)