r13317@catbus: nickm | 2007-06-08 14:39:59 -0400

bugfix: we were undercounting the number of authorities that recommended any given version by 1.  Backport candidate.


svn:r10537
This commit is contained in:
Nick Mathewson 2007-06-08 18:41:19 +00:00
parent 6a13e5535b
commit 2bb7005481
2 changed files with 14 additions and 3 deletions

View File

@ -21,7 +21,11 @@ Changes in version 0.2.0.3-alpha - 2007-??-??
o Minor bugfixes (hidden services): o Minor bugfixes (hidden services):
- Stop tearing down the whole circuit when the user asks for a - Stop tearing down the whole circuit when the user asks for a
connection to a port that the hidden service didn't configure. connection to a port that the hidden service didn't configure.
Resolves bug 444. Resolves bug 444. [Bugfix on 0.1.2.x]
o Minor bugfixes (versioning):
- Stop under-counting the number of authorities that recommend each
version. [Bugfix on 0.1.2.x]
Changes in version 0.2.0.2-alpha - 2007-06-02 Changes in version 0.2.0.2-alpha - 2007-06-02

View File

@ -3712,12 +3712,19 @@ compute_recommended_versions(time_t now, int client,
if (current && !strcmp(cp, current)) { if (current && !strcmp(cp, current)) {
++n_seen; ++n_seen;
} else { } else {
if (n_seen > n_versioning/2 && current) if (current)
log_info(LD_DIR,"version %s is recommended by %d authorities",
current, n_seen);
if (n_seen > n_versioning/2 && current) {
smartlist_add(recommended, current); smartlist_add(recommended, current);
n_seen = 0; /* XXXX020 shouldn't this be 1? */ }
n_seen = 1;
current = cp; current = cp;
} }
}); });
if (current)
log_info(LD_DIR,"version %s is recommended by %d authorities",
current, n_seen);
if (n_seen > n_versioning/2 && current) if (n_seen > n_versioning/2 && current)
smartlist_add(recommended, current); smartlist_add(recommended, current);