nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Do not set "once" when calling tor_bug_occurred_ from BUG().

Browse Source 
The "once" flag makes tor_bug_occurred_() say that future instances
of the warning will be suppressed -- but that's not something that
BUG() does.  Fixes bug 33095; bugfix on 0.4.1.1-alpha.
This commit is contained in:
Nick Mathewson 2020-01-30 09:43:34 -05:00
parent ec7f99e6ef
commit 2a1f8ea2e7
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changes/bug33095_041 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (logging, bug reporting):
- When logging a bug, do not say "Future instances of this warning
will be silenced" unless we are actually going to do
so. Previously we would say this whenever a BUG() check failed in
the code. Fixes bug 33095; bugfix on 0.4.1.1-alpha.

2
src/lib/log/util_bug.h
View File

@ -196,7 +196,7 @@
STMT_END STMT_END
#define BUG(cond) \ #define BUG(cond) \
(ASSERT_PREDICT_UNLIKELY_(cond) ? \ (ASSERT_PREDICT_UNLIKELY_(cond) ? \
(tor_bug_occurred_(SHORT_FILE__,__LINE__,__func__,"!("#cond")",1,NULL),1) \ (tor_bug_occurred_(SHORT_FILE__,__LINE__,__func__,"!("#cond")",0,NULL),1) \
: 0) : 0)
#endif /* defined(ALL_BUGS_ARE_FATAL) || ... */ #endif /* defined(ALL_BUGS_ARE_FATAL) || ... */