nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-28 14:23:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Would you believe that the software_versions field of routerlist_t was never actually used for anything?

Browse Source 
svn:r5064
This commit is contained in:
Nick Mathewson 2005-09-14 21:38:05 +00:00
parent e3adcbdb95
commit 27bbfe9dcf
3 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/or/or.h
View File

@ -845,12 +845,12 @@ typedef struct networkstatus_t {
typedef struct { typedef struct {
/** List of routerinfo_t. */ /** List of routerinfo_t. */
smartlist_t *routers; smartlist_t *routers;
/** Which versions of tor are recommended by this directory? */
char *software_versions;
/** When was the most recent directory that contributed to this list /** When was the most recent directory that contributed to this list
* published? */ * published? */
time_t published_on; time_t published_on;
#if 0 #if 0
/** Which versions of tor are recommended by this directory? */
char *software_versions;
time_t running_routers_updated_on; time_t running_routers_updated_on;
/** What is the most recently received running_routers structure? */ /** What is the most recently received running_routers structure? */
running_routers_t *running_routers; running_routers_t *running_routers;

4
src/or/routerlist.c
View File

@ -980,7 +980,6 @@ routerlist_free(routerlist_t *rl)
SMARTLIST_FOREACH(rl->routers, routerinfo_t *, r, SMARTLIST_FOREACH(rl->routers, routerinfo_t *, r,
routerinfo_free(r)); routerinfo_free(r));
smartlist_free(rl->routers); smartlist_free(rl->routers);
tor_free(rl->software_versions);
tor_free(rl); tor_free(rl);
} }
@ -1305,9 +1304,6 @@ router_load_routerlist_from_directory(const char *s,
}); });
smartlist_clear(new_list->routers); smartlist_clear(new_list->routers);
routerlist->published_on = new_list->published_on; routerlist->published_on = new_list->published_on;
tor_free(routerlist->software_versions);
routerlist->software_versions = new_list->software_versions;
new_list->software_versions = NULL;
routerlist_free(new_list); routerlist_free(new_list);
control_event_descriptors_changed(changed); control_event_descriptors_changed(changed);
smartlist_free(changed); smartlist_free(changed);

1
src/or/routerparse.c
View File

@ -539,7 +539,6 @@ router_parse_routerlist_from_directory(const char *str,
goto err; goto err;
} }
new_dir->software_versions = versions; versions = NULL;
new_dir->published_on = published_on; new_dir->published_on = published_on;
SMARTLIST_FOREACH(tokens, directory_token_t *, tok, token_free(tok)); SMARTLIST_FOREACH(tokens, directory_token_t *, tok, token_free(tok));