nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 13:13:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove SR_COMMIT_LEN workaround

Browse Source 
Now that base64_decode() checks the destination buffer length against
the actual number of bytes as they're produced, shared_random.c no
longer needs the "SR_COMMIT_LEN+2" workaround.
This commit is contained in:
Taylor Yu 2017-04-07 18:06:13 -04:00
parent 2b38bb28b4
commit 26dd4d92cf
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/or/shared_random.c
View File

@ -230,9 +230,7 @@ commit_decode(const char *encoded, sr_commit_t *commit)
{
int decoded_len = 0;
size_t offset = 0;
/* XXX: Needs two extra bytes for the base64 decode calculation matches
* the binary length once decoded. #17868. */
char b64_decoded[SR_COMMIT_LEN + 2];
char b64_decoded[SR_COMMIT_LEN];
tor_assert(encoded);
tor_assert(commit);
@ -284,9 +282,7 @@ STATIC int
reveal_decode(const char *encoded, sr_commit_t *commit)
{
int decoded_len = 0;
/* XXX: Needs two extra bytes for the base64 decode calculation matches
* the binary length once decoded. #17868. */
char b64_decoded[SR_REVEAL_LEN + 2];
char b64_decoded[SR_REVEAL_LEN];
tor_assert(encoded);
tor_assert(commit);