Merge branch 'maint-0.4.7'

This commit is contained in:
David Goulet 2022-07-27 11:33:19 -04:00
commit 22cb4c23d0
3 changed files with 7 additions and 2 deletions

5
changes/bug40645 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (defense in depth):
- Change a test in the netflow padding code to make it more
_obviously_ safe against remotely triggered crashes.
(It was safe against these before, but not obviously so.)
Fixes bug 40645; bugfix on 0.3.1.1-alpha.

View File

@ -186,7 +186,7 @@ channelpadding_get_netflow_inactive_timeout_ms(const channel_t *chan)
high_timeout = MAX(high_timeout, chan->padding_timeout_high_ms); high_timeout = MAX(high_timeout, chan->padding_timeout_high_ms);
} }
if (low_timeout == high_timeout) if (low_timeout >= high_timeout)
return low_timeout; // No randomization return low_timeout; // No randomization
/* /*

View File

@ -668,7 +668,7 @@ command_process_destroy_cell(cell_t *cell, channel_t *chan)
* DESTROY cell down the circuit so relays can stop queuing in-flight * DESTROY cell down the circuit so relays can stop queuing in-flight
* cells for this circuit which helps with memory pressure. */ * cells for this circuit which helps with memory pressure. */
log_debug(LD_OR, "Received DESTROY cell from n_chan, closing circuit."); log_debug(LD_OR, "Received DESTROY cell from n_chan, closing circuit.");
circuit_mark_for_close(circ, END_CIRC_REASON_TORPROTOCOL); circuit_mark_for_close(circ, reason | END_CIRC_REASON_FLAG_REMOTE);
} }
} }
} }